From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix contrib/auto_explain to not cause problems in parallel
 worke
In-reply-to: <20190604011354.GD1529@paquier.xyz>
References: <E1hXv5x-0002VX-HF@gemulon.postgresql.org>
 <20190604011354.GD1529@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 04 Jun 2019 10:13:54 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <54158.1559611016.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 03 Jun 2019 21:16:56 -0400
Message-ID: <54159.1559611016@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Jun 03, 2019 at 10:06:21PM +0000, Tom Lane wrote:
>> Fix contrib/auto_explain to not cause problems in parallel workers.

> This has broken the builds on Windows for 9.6 and 10:
> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Dwoodlous=
e&dt=3D2019-06-04%2000%3A42%3A07&stg=3Dmake

Ooops.

> This gets included as a dependency because of the call to
> IsParallelWorker() you have added in this commit, and I think that
> this can be fixed by adding PGDLLIMPORT to the variable in
> parallel.h.  Would you fix it or should I?

Yeah, I see we already did that in later branches.  I'll go fix it,
thanks for the heads-up!

			regards, tom lane