Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mife0-0006iP-Jn for pgsql-committers@arkaria.postgresql.org; Thu, 04 Nov 2021 16:31:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mifdz-0001lX-IS for pgsql-committers@arkaria.postgresql.org; Thu, 04 Nov 2021 16:31:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mifdz-0001lN-CF for pgsql-committers@lists.postgresql.org; Thu, 04 Nov 2021 16:31:15 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mifdw-0005d7-AL for pgsql-committers@lists.postgresql.org; Thu, 04 Nov 2021 16:31:14 +0000 Received: (Authenticated sender: adsend@dunslane.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id EEA4240013; Thu, 4 Nov 2021 16:31:07 +0000 (UTC) Message-ID: <5430d13d-baf6-a3d5-3ed8-e22056855068@dunslane.net> Date: Thu, 4 Nov 2021 12:31:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: pgsql: Fix snapshot reference leak if lo_export fails. Content-Language: en-US To: Heikki Linnakangas , Daniel Gustafsson Cc: pgsql-committers@lists.postgresql.org References: From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 11/3/21 13:47, Heikki Linnakangas wrote: > On 03/11/2021 13:06, Daniel Gustafsson wrote: >>> On 3 Nov 2021, at 10:44, Heikki Linnakangas >>> wrote: >> >>> Fix snapshot reference leak if lo_export fails. >> >> This commit seems to lack the update in largeobject_1 as per hamerkop >> in: > > Fixed, thanks! > > I'm a bit surprised none of the other Windows systems on the buildfarm > complained. The difference in largeobject_1 output is apparently that > the 'tenk.data' file uses Windows line endings. I guess that on all > the other Windows hosts, git has been configured to use Unix line > endings. no, on drongo this comes up blank:     git config --get --show-origin core.eol These days I often set:     git config --system core.eol lf     git config --system core.autocrlf input because it makes repos checked out with Windows native git work nicely with msys git, but I haven't done that on drongo. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com