Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vklK3-001pCZ-2W for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Jan 2026 15:49:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vklK2-00ERnq-2S for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Jan 2026 15:49:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vklK2-00ERng-1T for pgsql-hackers@lists.postgresql.org; Tue, 27 Jan 2026 15:49:42 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vklK0-002aRF-1S; Tue, 27 Jan 2026 15:49:41 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 60RFndnI544728; Tue, 27 Jan 2026 10:49:39 -0500 From: Tom Lane To: Robert Haas cc: Amit Kapila , PostgreSQL Hackers Subject: Re: pgsql: Prevent invalidation of newly synced replication slots. In-reply-to: <428236.1769526672@sss.pgh.pa.us> References: <428236.1769526672@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Tue, 27 Jan 2026 10:11:12 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <544726.1769528979.1@sss.pgh.pa.us> Date: Tue, 27 Jan 2026 10:49:39 -0500 Message-ID: <544727.1769528979@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I wrote: > Robert Haas writes: >> This commit has broken CI for me. > Hmm, I wonder why the buildfarm seems fine with it ... I'm prepared > to believe a Windows-only problem, but at least hamerkop has run > since 851f664. D'oh: hamerkop doesn't run any TAP tests, let alone ones that require --enable-injection-points. So that success proves nothing. Our other Windows animals (drongo, fairywren, unicorn) seem to be configured with -Dtap_tests=enabled, but nothing about injection points, so they will also skip 046_checkpoint_logical_slot. Seems like a bit of a blind spot in the buildfarm. regards, tom lane