Feedback-ID: i7c334307:Fastmail
Content-Type: multipart/signed;
	boundary="Apple-Mail=_4BCB023D-4825-477A-BD10-EDA9D6B36EB4";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\))
Subject: Re: extension_control_path and "directory"
From: "David E. Wheeler" <david@justatheory.com>
In-Reply-To: 
 <CAFY6G8d-4Nb34dqb_92kGrXfo4tO012m-9YzznKmb7f5JhJpEA@mail.gmail.com>
Date: Thu, 24 Apr 2025 18:27:37 -0400
Cc: Christoph Berg <myon@debian.org>,
 Peter Eisentraut <peter@eisentraut.org>,
 pgsql-hackers@lists.postgresql.org
Message-Id: <546E7C54-D2F4-4DBB-9A06-EBBF90265A2C@justatheory.com>
References: <E1tumbY-003Dl3-2o@gemulon.postgresql.org>
 <aAi1VACxhjMhjFnb@msg.df7cb.de>
 <CAFY6G8dDjimxaSQV68ExWMmrAi8xNhiOT3RZOD8oQZmdGCG5Jg@mail.gmail.com>
 <aAjwPjsIElh17Nby@msg.df7cb.de>
 <3C304C9E-976C-4FB9-A883-707E0B90756A@justatheory.com>
 <CAFY6G8c=W8CMFwcx2fA0RSFtvw=5BDGKOjGSV=nEUiZ6use2Bw@mail.gmail.com>
 <aAoQkqwktHQI5KLO@msg.df7cb.de>
 <CAFY6G8d-4Nb34dqb_92kGrXfo4tO012m-9YzznKmb7f5JhJpEA@mail.gmail.com>
To: Matheus Alcantara <matheusssilv97@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/546E7C54-D2F4-4DBB-9A06-EBBF90265A2C%40justatheory.com>
Precedence: bulk


--Apple-Mail=_4BCB023D-4825-477A-BD10-EDA9D6B36EB4
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On Apr 24, 2025, at 11:18, Matheus Alcantara <matheusssilv97@gmail.com> =
wrote:

> In v2 I've moved the logic to remove the /extension to
> parse_extension_control_file(), do you think that this Assert on this
> function would still be wrong? IIUC we should always have /extension =
at
> the end of "control_dir" at this place, because the
> extension_control_path GUC will omit the /extension at the end and we
> will force it to have the suffix on the path at
> find_extension_control_filename() and
> get_extension_control_directories() functions. I'm missing something
> here?

I took this patch for a spin and managed to make it core dump. How? Well =
I installed semver with this command:

```sh
make prefix=3D/Users/david/Downloads install
```

Then set the search paths and restarted:

```ini
extension_control_path =3D =
'/Users/david/Downloads/share/extension:$system'
dynamic_library_path =3D '/Users/david/Downloads/lib:$libdir'
```

Then I connected and ran `CREATE EXTENSION semver` and it segfaulted. I =
poked around for a few minutes and realized that my prefix is not what I =
expected. Because it doesn=E2=80=99t contain the string =E2=80=9Cpostgres=E2=
=80=9D, PGXS helpfully adds it. The actual paths are:

```ini
extension_control_path =3D =
'/Users/david/Downloads/share/postgresql/extension:$system'
dynamic_library_path =3D '/Users/david/Downloads/lib/postgresql:$libdir'
```

With that fix it no longer segafulted.

So I presume something crashes when a directory or file doesn=E2=80=99t =
exist.

But I am not at all sure we want this prefix behavior for installing =
extensions. I get that has been the behavior for setting the main =
sharedir and libdir for Postgres, but I don=E2=80=99t know that it makes =
sense for extension prefixes.

Best,

David


--Apple-Mail=_4BCB023D-4825-477A-BD10-EDA9D6B36EB4
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd+KfmbOQis6ZycGGkt9idPjIgfEFAmgKutkACgkQkt9idPjI
gfEAQBAAgarmRmJG4qGI0B96X0GjDSMU3Y+jvuHuhsHrdrBKM1iMDRA5mve0eRqG
V1j7HpRCWJmz53WJQ7QsbIwgssLt/vjmXOdL6gjbC7HPjTy+98WoSQDEy9rgkxMv
uyNJY629P6ia81sa2I9v3kmHGX1Ef2QAk7+AyxggNeQ3EOc0jePVshAanqRHD7bh
6St6Ty9cpy55JulypGf/CzK6wV4Rqo6DN0FyEpG/TM6sEt3GYwazqnl0k1LLVoMf
x47ncIHEwnJr0G8RI/1kCxclhdYOXyPQKFVbraOVJ4W3S2xSjcQMhk0FAHPlUpQp
v0POU8sAv0Vg6M4HUQQjdPyZOCi7ae8XZme1n8F9T7Mtj+22VrvSiUS/H7RlmMtc
SmP8kiGo4RHTNATy4tB2QmXcDhWnPZFvZOSs/wmmtfxNUsmcD+MIzPSIRUri4aBZ
rWR1c6xYLW9xD9APNVeoZqKcuIQmZrTs2tl3uerUreSxa/hpAFrTvpkpz93SDPML
W20ziTuZNg4B8mNK2TuX2/0LmTgboxUPz7aOxW+cL9fglt7tXCurrthS3C/mebNA
lMN8FCXH4azuJyVgvrwO/PR4AXonIv3fS1g6Q9pfdoTF0mnjAaZ/rs1aoIymphdu
6JgLx2JTrEgGMQ94xP9Puku6CGxIuMSpvtyIqj8X75bFF8p4Gew=
=yNz+
-----END PGP SIGNATURE-----

--Apple-Mail=_4BCB023D-4825-477A-BD10-EDA9D6B36EB4--