Feedback-ID: i675e48f3:Fastmail
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\))
Subject: Re: pgsql: Prevent invalidation of newly synced replication slots.
From: Greg Burd <greg@burd.me>
In-Reply-To: <544727.1769528979@sss.pgh.pa.us>
Date: Tue, 27 Jan 2026 11:53:38 -0500
Cc: Robert Haas <robertmhaas@gmail.com>,
 Amit Kapila <akapila@postgresql.org>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <54F8BC8B-6F9D-4B91-8B68-AA02B7643B94@burd.me>
References: <E1vkc3p-002uNr-0e@gemulon.postgresql.org>
 <CA+TgmobdVhO0ckZfsBZ0wqDO4qHVCwZZx8sf=EinafvUam-dsQ@mail.gmail.com>
 <428236.1769526672@sss.pgh.pa.us> <544727.1769528979@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/54F8BC8B-6F9D-4B91-8B68-AA02B7643B94%40burd.me>
Precedence: bulk


> On Jan 27, 2026, at 10:49=E2=80=AFAM, Tom Lane <tgl@sss.pgh.pa.us> =
wrote:
>=20
> I wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> This commit has broken CI for me.
>=20
>> Hmm, I wonder why the buildfarm seems fine with it ... I'm prepared
>> to believe a Windows-only problem, but at least hamerkop has run
>> since 851f664.
>=20
> D'oh: hamerkop doesn't run any TAP tests, let alone ones that require
> --enable-injection-points.  So that success proves nothing.
>=20
> Our other Windows animals (drongo, fairywren, unicorn) seem to be
> configured with -Dtap_tests=3Denabled, but nothing about injection
> points, so they will also skip 046_checkpoint_logical_slot.
> Seems like a bit of a blind spot in the buildfarm.
>=20
> regards, tom lane
>=20


I'll see if I can update unicorn today to enable injection points to add =
some coverage on Win11/ARM64/MSVC.  No promises that will be diagnostic =
at all, but it seems like a good idea.


-Dinjection_points=3Dtrue


-greg=