Message-ID: <553EDA8A.9090806@dunslane.net>
Date: Mon, 27 Apr 2015 20:55:38 -0400
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Peter Eisentraut <peter_e@gmx.net>,
 Michael Paquier <michael.paquier@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
CC: pgsql-committers@postgresql.org
Subject: Re: pgsql: Add transforms feature
References: <E1YmNw0-0002Kb-3Q@gemulon.postgresql.org>
	<18844.1430066190@sss.pgh.pa.us>
 <CAB7nPqRE6PpdMbwvytXCcKsnwg-TKM=0sfsH=DoCRKEvJVusKw@mail.gmail.com>
 <553E29B5.9000102@gmx.net> <553ECC34.2090104@dunslane.net>
In-Reply-To: <553ECC34.2090104@dunslane.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org


On 04/27/2015 07:54 PM, Andrew Dunstan wrote:
>
> On 04/27/2015 08:21 AM, Peter Eisentraut wrote:
>> On 4/27/15 2:23 AM, Michael Paquier wrote:
>>> On Mon, Apr 27, 2015 at 1:36 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>>> Peter Eisentraut <peter_e@gmx.net> writes:
>>>>> Add transforms feature
>>>> I don't know why this patch is fooling around with compile/link flags,
>>>> but it's broken at least prairiedog and some of the Windows critters.
>>> It breaks as well on all the Windows machines using MS or VC 
>>> toolchains...
>> The failure on bowerbird (Windows msvc) is because the build system
>> needs to be told to add additional include directories to the 
>> compilation.
>>
>> The failure on frogmouth (Windows gcc) is because of some conflict with
>> perl headers.  I must have missed a trick that was already in use for
>> plperl.
>>
>> Help in either case, but especially the first one, is welcome.
>>
>>
>
>
> I haven't looked at the MSVC case yet, but one thing I notice on 
> jacana (Windows 8.1, gcc) is that the order of include directories is 
> different. When compiling plperl, the perl CORE directory is last in 
> the include list, whereas for compiling hstore_plperl it's second from 
> the beginning. I have no idea yet if that makes any difference, but 
> would not be at all surprised it if did. We should probably be 
> mimicking what the plperl makefile does.
>
> Incidentally, I notice that hstore_plperl.c doesn't have a copyright 
> notice nor a single comment, not even at the start of the public 
> functions. That seems less than good.
>
>

w.r.t MSVC builds, it looks like we need entries in 
$contrib_extraincludes in src/tools/msvc/Mkvcbuild.pm at the very least.

cheers

andrew


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers