Message-ID: <553FAF6D.3070703@dunslane.net>
Date: Tue, 28 Apr 2015 12:03:57 -0400
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Michael Paquier <michael.paquier@gmail.com>
CC: Peter Eisentraut <peter_e@gmx.net>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-committers@postgresql.org
Subject: Re: pgsql: Add transforms feature
References: <E1YmNw0-0002Kb-3Q@gemulon.postgresql.org>
	<18844.1430066190@sss.pgh.pa.us>
	<CAB7nPqRE6PpdMbwvytXCcKsnwg-TKM=0sfsH=DoCRKEvJVusKw@mail.gmail.com>
	<553E29B5.9000102@gmx.net>	<553ECC34.2090104@dunslane.net>
	<553EDA8A.9090806@dunslane.net>
	<CAB7nPqT1k22QhvbX7npTY0BqLgGTPQU1eN8u78LBAuy57Y8jRg@mail.gmail.com>
 <CAB7nPqRWEgqGQqTc-0bdRTBGbbnPyDEStnOEJw6ffFw=504nhQ@mail.gmail.com>
 <553FAC70.2070309@dunslane.net>
In-Reply-To: <553FAC70.2070309@dunslane.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org


[switching to -hackers]

On 04/28/2015 11:51 AM, Andrew Dunstan wrote:
>
> On 04/28/2015 09:04 AM, Michael Paquier wrote:
>> On Tue, Apr 28, 2015 at 10:01 AM, Michael Paquier
>> <michael.paquier@gmail.com> wrote:
>>> On Tue, Apr 28, 2015 at 9:55 AM, Andrew Dunstan wrote:
>>>> w.r.t MSVC builds, it looks like we need entries in 
>>>> $contrib_extraincludes
>>>> in src/tools/msvc/Mkvcbuild.pm at the very least.
>>> If our goal is to put back to green the Windows nodes as quick as
>>> possible, we could bypass their build this way , and we'll
>>> additionally need to update the install script and
>>> vcregress.pl/contribcheck to bypass those modules accordingly. Now I
>>> don't think that we should make the things produced inconsistent.
>> OK, attached are two patches to put back the buildfarm nodes using 
>> MSVC to green
>> - 0001 adds support for build and installation of the new transform
>> modules: hstore_plperl, hstore_plpython and  ltree_plpython. Note that
>> this patch is enough to put back the buildfarm to a green state for
>> MSVC, but it disables the regression tests for those modules,
>> something addressed in the next patch...
>> - 0002 adds support for regression tests for the new modules. The
>> thing is that we need to check the major version version of Python
>> available in configuration and choose what are the extensions to
>> preload before the tests run. It is a little bit hacky... But it has
>> the merit to work, and I am not sure we could have a cleaner solution
>> by looking at the Makefiles of the transform modules that use
>> currently conditions based on $(python_majorversion).
>> Regards,
>
>
> I have pushed the first of these with some tweaks.
>
> I'm looking at the second.
>
>


Regarding this second patch - apart from the buggy python version test 
which I just fixed in the first patch, I see this:

    +       if ($pyver eq "2")
    +       {
    +           push @opts, "--load-extension=plpythonu";
    +           push @opts, '--load-extension=' . $module . 'u';
    +       }


But what do we do for Python3?

Do we actually have a Windows machine building with Python3?

cheers

andrew


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers