Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1YtEdk-0006Vt-2K for pgsql-committers@arkaria.postgresql.org; Fri, 15 May 2015 12:22:56 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1YtEdj-0001bY-Iw for pgsql-committers@arkaria.postgresql.org; Fri, 15 May 2015 12:22:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1YtEdi-0001bS-SB for pgsql-committers@postgresql.org; Fri, 15 May 2015 12:22:54 +0000 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1YtEYn-00082c-Vh for pgsql-committers@postgresql.org; Fri, 15 May 2015 12:17:52 +0000 Received: by wicnf17 with SMTP id nf17so134744368wic.1 for ; Fri, 15 May 2015 05:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=ua5gQjEklu+YHAGZgKJo4mVdaPgQmtCbJi0wDEpz52s=; b=bM6RtH02GbU4Dq4YBYbhdmzGQP0Wrz7nSQRW8OJLE5ASS9eZa6u8KURJ+2yuUPsmbj CcVuuJ505mSTFmhRNvtZDygE44eyYCCpa3qyakIdIvLqCh/LRArtXsnplvn+KkbYYa5L PB2pboHAJuGj9KYdnrzGsWIkC6FwTBPnWIA2NEu1k+1qyx6Yj+pZLxX1i8RWeLFRxfE4 HUHvBhP7R0GQEJmiEuKJqFub0h7x4PZmMkotFiWI87/l4XEOQQmSNA6tKqCZGVbAgRWB KI8cRpXjbVhnyto5Lu771oCT3vZ9l6QtrQp3IMW+Q9w86WYxkR2hSlxtLwrx8nCLErs6 GtFw== X-Received: by 10.194.220.100 with SMTP id pv4mr18141187wjc.71.1431692269198; Fri, 15 May 2015 05:17:49 -0700 (PDT) Received: from [192.168.1.99] (dsl-hkibrasgw1-58c38f-82.dhcp.inet.fi. [88.195.143.82]) by mx.google.com with ESMTPSA id qs2sm2220109wjc.31.2015.05.15.05.17.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 May 2015 05:17:48 -0700 (PDT) Message-ID: <5555E3EB.6010200@iki.fi> Date: Fri, 15 May 2015 15:17:47 +0300 From: Heikki Linnakangas Reply-To: hlinnaka@iki.fi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Fujii Masao CC: pgsql-committers Subject: Re: pgsql: Allow GiST distance function to return merely a lower-bound. References: In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org On 05/15/2015 03:05 PM, Fujii Masao wrote: > Seems this patch causes the regression test of pg_trgm fail. > The regression diff that I got is: > > *** /home/postgres/pgsql/head/contrib/pg_trgm/expected/pg_trgm.out > 2013-07-23 16:46:22.212488785 +0900 > --- /home/postgres/pgsql/head/contrib/pg_trgm/results/pg_trgm.out > 2015-05-15 20:59:16.574926732 +0900 > *************** > *** 2332,2343 **** > (3 rows) > > select t <-> 'q0987wertyu0988', t from test_trgm order by t <-> > 'q0987wertyu0988' limit 2; > ! ?column? | t > ! ----------+------------- > ! 0.411765 | qwertyu0988 > ! 0.5 | qwertyu0987 > ! (2 rows) > ! > drop index trgm_idx; > create index trgm_idx on test_trgm using gin (t gin_trgm_ops); > set enable_seqscan=off; > --- 2332,2338 ---- > (3 rows) > > select t <-> 'q0987wertyu0988', t from test_trgm order by t <-> > 'q0987wertyu0988' limit 2; > ! ERROR: index returned tuples in wrong order > drop index trgm_idx; > create index trgm_idx on test_trgm using gin (t gin_trgm_ops); > set enable_seqscan=off; Hmm, OK. pg_trgm works for me, but I'll take a look. (rover_firefly also went red, due to rounding differences in the regression test) - Heikki -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers