Message-ID: <55ACA793.7080400@iki.fi>
Date: Mon, 20 Jul 2015 10:47:31 +0300
From: Heikki Linnakangas <hlinnaka@iki.fi>
Reply-To: hlinnaka@iki.fi
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.7.0
MIME-Version: 1.0
To: Alvaro Herrera <alvherre@2ndquadrant.com>
CC: Michael Paquier <michael.paquier@gmail.com>,
 Kevin Grittner <kgrittn@ymail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints
 at ALTER TABLE ... TY
References: <E1ZEvoc-0002RV-Vh@gemulon.postgresql.org>
 <81620362.883169.1437142581761.JavaMail.yahoo@mail.yahoo.com>
 <CAB7nPqTnAyTwrnXfyJdmovu0B991KK3tymgW5NNtPWyU=fhNzQ@mail.gmail.com>
 <55A94C2D.1010204@iki.fi> <20150718131528.GV2301@postgresql.org>
In-Reply-To: <20150718131528.GV2301@postgresql.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 07/18/2015 04:15 PM, Alvaro Herrera wrote:
> Heikki Linnakangas wrote:
>> If it's there just to so you can run the regression tests that come
>> with it, it might make sense to just add a "default" case to that
>> switch to handle any unrecognized commands, and perhaps even remove
>> the cases for the currently untested subcommands as it's just dead
>> code.
>
> Well, I would prefer to have an output that says "unrecognized" and then
> add more test cases to the SQL files so that there's not so much dead
> code.  I prefer that to removing the C support code, because then as
> we add extra tests we don't need to modify the C source.

Ok. I added a case for AT_ReAddComment, and also a default-case that 
says "unrecognized".
- Heikki


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers