From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Add hooks for session start and session end
In-reply-to: <6a231271-671f-a5b0-e4ba-a0ae57ba50cd@2ndQuadrant.com>
References: <E1eEzZG-0001kP-KI@gemulon.postgresql.org>
 <10176.1510764611@sss.pgh.pa.us>
 <575d6fa2-78d0-4456-8600-302fc35b2591@dunslane.net>
 <21509.1510772165@sss.pgh.pa.us>
 <762a0864-a831-1009-c2c7-297695d1e3e4@2ndQuadrant.com>
 <6a231271-671f-a5b0-e4ba-a0ae57ba50cd@2ndQuadrant.com>
Comments: In-reply-to Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
	message dated "Wed, 15 Nov 2017 16:11:13 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <5680.1510781444.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Wed, 15 Nov 2017 16:30:44 -0500
Message-ID: <5681.1510781444@sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 11/15/2017 02:17 PM, Andrew Dunstan wrote:
>> Yeah, that was my first instinct. But then how do the test_rls_hooks
>> tests succeed? They too have a shared_preload_library.

> Aha, it does
>     LOAD 'test_rls_hooks';
> at the start of its script. Of course we can't do that here.

> Not sure what the best way to resolve this is. For now I'm inclined just
> to override the installcheck target in the module's makefile and disable
> it in vcregress.pl.

Yeah.

> Maybe we need to shift from installcheck to check mode for these
> modules. That would involve a buildfarm script change.

Seems like expending an awful lot of cycles in support of a rather trivial
feature.

			regards, tom lane