Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFybp-00D1HC-5f for pgsql-committers@arkaria.postgresql.org; Wed, 20 Dec 2023 15:35:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rFybn-00E0Tg-My for pgsql-committers@arkaria.postgresql.org; Wed, 20 Dec 2023 15:35:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFybn-00E0TW-Bt for pgsql-committers@lists.postgresql.org; Wed, 20 Dec 2023 15:35:43 +0000 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rFybk-00BLqK-D4 for pgsql-committers@lists.postgresql.org; Wed, 20 Dec 2023 15:35:42 +0000 Received: by mail-qt1-x833.google.com with SMTP id d75a77b69052e-4277e5a8f82so10607281cf.1 for ; Wed, 20 Dec 2023 07:35:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dunslane-net.20230601.gappssmtp.com; s=20230601; t=1703086539; x=1703691339; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+HBJoyLM1ZmcBB1g6XGdJrE0CnPIkSnPkvk0xvGcC1Q=; b=zsW+I6V1oLtpJlGF5siG6gpY+X/ZCoUpxXBN4UC9/akzD/gz/J5bvsp3zG5/JY6nf3 0NJ/kinEYZYI/1Z20j3kzHRERQZZWOm9t7dc6bwfpOBtD0S66we5Yb4sQKiPi37/SUxW Si0u6NEZ5TNUVQlRVPvVJFduEkr6oVBe+awy2mXQHLsu9d4tMur3gSpbdi9D9xxlUZtz AyXqJS0LwQQoVWqwzPL02vl1n6euFocWNkdjXdVDA0XVKuuqNWtapEYc6IEIFC3c0teF UE0av0wZ6KDnKCAf5ZD5hFuQ13va5RXhyjO+Xdgam7h+3AfHNtaBRyM8QnjYoFPYCE9i C+pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703086539; x=1703691339; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+HBJoyLM1ZmcBB1g6XGdJrE0CnPIkSnPkvk0xvGcC1Q=; b=P/ytVwGGJalpbv2RzmvgssukRO+y5xfwqRVF3IBLEYxEfuIymEsuZiwLwtUtFYv73+ nOZJZc41BasIOLH6mNRMNyaubYUlwkVpojLWmB+4p0vfUenEdX9cBFvWgEbF8QhfDhTz 9ffzBYyxh3s0+BuqEW3DcT6r7k6d7OSsxMKYPKoqpmRgVWju0ZB4jBDLeO4l7s1UO6xV PXxWu1XIH0xStk9NBJaOo7tGshNNRGUYaXB54ul1rhYrNROjiYffh9iv3LwJ5ef8lF6v T7pTPL5nSF9y/CuBnq7zh8udRXB53OT+JVL6Jvty4In7GQOfknCTNJmbRNqNe1Khykne EmGg== X-Gm-Message-State: AOJu0YyUYtCornxJ5tBj90zV2pUaEyH+kh+2VytTqepqwv8kig2xt450 e9HxwwnqotPgEKc4+VSlMye3Tw== X-Google-Smtp-Source: AGHT+IEPcp8AJ6toD2I5hQmyUtm1QlPU0KjVJ60AgTEgVW6rjEbYP/KZjtFOmSPOlvHVFzLgWE5qCA== X-Received: by 2002:ac8:5ad1:0:b0:425:4043:18b9 with SMTP id d17-20020ac85ad1000000b00425404318b9mr29851143qtd.108.1703086538931; Wed, 20 Dec 2023 07:35:38 -0800 (PST) Received: from ?IPV6:2605:a601:91bc:f600::2bb? ([2605:a601:91bc:f600::2bb]) by smtp.googlemail.com with ESMTPSA id cj22-20020a05622a259600b0042545c7beccsm1174825qtb.59.2023.12.20.07.35.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 07:35:38 -0800 (PST) Message-ID: <5762e81d-2a2a-b08d-a3ff-f2344a300171@dunslane.net> Date: Wed, 20 Dec 2023 10:35:37 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: pgsql: Remove MSVC scripts Content-Language: en-US To: Robert Haas , Michael Paquier Cc: pgsql-committers@lists.postgresql.org References: From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-12-20 We 09:19, Robert Haas wrote: > On Tue, Dec 19, 2023 at 7:45 PM Michael Paquier wrote: >> Remove MSVC scripts > I think it's because of this commit that koel and crake now have this complaint: > > > ./src/tools/version_stamp.pl syntax OK > Can't locate Win32/Registry.pm in @INC (you may need to install the > Win32::Registry module) (@INC entries checked: src/test/perl > src/tools/msvc src/backend/catalog src/backend/utils/mb/Unicode > src/bin/pg_rewind src/test/ssl/t src/tools/msvc/dummylib > /usr/local/lib64/perl5/5.38 /usr/local/share/perl5/5.38 > /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl > /usr/lib64/perl5 /usr/share/perl5) at ./src/tools/win32tzlist.pl line > 21. > BEGIN failed--compilation aborted at ./src/tools/win32tzlist.pl line 21. > > win32tzlist.pl still says "use Win32::Registry" but the commit removed > src/tools/msvc/dummylib/Win32/Registry.pm. > Yeah, the commit removed our dummy version of Win32/Registry.pm. I have disabled the test for that file on branches later than 16, and koel and crake are back to green. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com