Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJzvc-0004g4-Gu for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Feb 2022 15:39:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nJzva-0006vw-UX for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Feb 2022 15:39:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJzva-0006vn-8D for pgsql-hackers@lists.postgresql.org; Tue, 15 Feb 2022 15:39:42 +0000 Received: from mail-vs1-xe34.google.com ([2607:f8b0:4864:20::e34]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nJzvW-0006B1-G5 for pgsql-hackers@postgresql.org; Tue, 15 Feb 2022 15:39:41 +0000 Received: by mail-vs1-xe34.google.com with SMTP id e26so6766475vso.3 for ; Tue, 15 Feb 2022 07:39:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joeconway.com; s=google; h=message-id:date:mime-version:user-agent:content-language:to :references:from:subject:in-reply-to:content-transfer-encoding; bh=1+/a5bQS4haKjIm8re6KCR4dJ19NiU17soF8uv9EJx0=; b=YhaTrF1u8gbur4JeXI+c59c3IlBga5yNsLwTUk177kgLI+d4N2cUn1WWzaNekOTLyo GX6Sq9WiSVEV2CgcKKHK1f3i6+oO20tJkqWAmY5v5ZirUADtCA1YLaumuiJUZNt2McQj v6DI23j+thZmiXS4T5uymUN8N8kBx2oKG8jJFEynp60AJ+hqFcdt26PnRNwmZcXl/Qku kUvzyYdq+OFUr8l5zybvCqNCq8RwV7nuvijTcMZiOYGiwzmWohe8MSHCMtYzy5TpTq54 7TJhjRaobWQoaxUYIsLLc7x0E4DOlJ/UOZGRIPxl5qR/Op5p9jghfNVaX9JGpobkdz3u rn4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=1+/a5bQS4haKjIm8re6KCR4dJ19NiU17soF8uv9EJx0=; b=KkaIVKroMOIwn51BF7ZVlSNzUgUXLXS4BVZf+Wc3Rx817xtqyRbqUvNhTK84dswPQk A2j9VUfpcdp3jyHwvq1+8CbPaF2kXEqYhed4QKtHW+ustwOah4a9GNlq6duaawXwNwvV URDxZhHOj0/wSCrJ8FfyGS1c5eAcHxwkeGW1jn+TWmlrpwXXcNe2t1BQOeNP9hPK1w3C IGKA08GoZ5ztLxkCZ5tWQqPgOJy225WR9uh+vOy1dOMbuQyfxQuaSE7ABMl2G5jeY3ee yOl0ZD6O1fugC7AIJrwcdHZPNaRJsoWN9OL3na84uAd9i8WK15FQuVkxo/Xyumem0n3f ZqWQ== X-Gm-Message-State: AOAM531cQQoz0/UaJhjj6Y3sHC7HFnJJt/JMLPiNSKF7JRibO1cNJcYz wdymDZ9og7g+qr6JOD7GLKlevA== X-Google-Smtp-Source: ABdhPJyX+t2wRbiBrSxIOIStMftissXgzuSxvX+Ip4HcwN6J53CTnkkklRQr8ulEQ71ERBJ1iBMqjg== X-Received: by 2002:a05:6102:2926:: with SMTP id cz38mr1635306vsb.83.1644939575730; Tue, 15 Feb 2022 07:39:35 -0800 (PST) Received: from [192.168.4.41] (072-017-018-098.res.spectrum.com. [72.17.18.98]) by smtp.gmail.com with ESMTPSA id l5sm1224773vsj.17.2022.02.15.07.39.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Feb 2022 07:39:35 -0800 (PST) Message-ID: <58cca3e9-53b8-e824-7cd4-6e59b4e242b1@joeconway.com> Date: Tue, 15 Feb 2022 10:39:34 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Peter Eisentraut , PostgreSQL-development References: From: Joe Conway Subject: Re: pgsql: Move scanint8() to numutils.c In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2/14/22 16:18, Peter Eisentraut wrote: > Move scanint8() to numutils.c > > Move scanint8() to numutils.c and rename to pg_strtoint64(). We > already have a "16" and "32" version of that, and the code inside the > functions was aligned, so this move makes all three versions > consistent. The API is also changed to no longer provide the errorOK > case. Users that need the error checking can use strtoi64(). > > Reviewed-by: John Naylor > Discussion: https://www.postgresql.org/message-id/flat/b239564c-cad0-b23e-c57e-166d883cb97d@enterprisedb.com (moving to hackers) I guess shame on me for not noticing the thread, but I don't see any discussion about the potential for breakage to external projects. scanint8() is exported, and this change breaks at least two extensions I maintain. A quick scan (no pun intended ;-)) of github shows other potential breakage, including at least older (still open source) versions of pglogical. Joe -- Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure Enterprises Consulting, Training, & Open Source Development