Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mH9F2-0000jt-0w for pgsql-committers@arkaria.postgresql.org; Fri, 20 Aug 2021 18:27:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mH9F0-0000lN-RY for pgsql-committers@arkaria.postgresql.org; Fri, 20 Aug 2021 18:27:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mH9F0-0000ky-Lh for pgsql-committers@lists.postgresql.org; Fri, 20 Aug 2021 18:27:42 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mH9Eu-0008Qe-C5 for pgsql-committers@lists.postgresql.org; Fri, 20 Aug 2021 18:27:41 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 012B02E9B0DD for ; Fri, 20 Aug 2021 20:27:34 +0200 (CEST) Received: from s934.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id E62662E28B59; Fri, 20 Aug 2021 20:27:33 +0200 (CEST) Received: from s472.loopia.se (unknown [172.22.191.5]) by s934.loopia.se (Postfix) with ESMTP id E3BC67CE98E; Fri, 20 Aug 2021 20:27:33 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s630.loopia.se ([172.22.191.6]) by s472.loopia.se (s472.loopia.se [172.22.190.12]) (amavisd-new, port 10024) with LMTP id B0xWAkNq0FVp; Fri, 20 Aug 2021 20:27:33 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from [192.168.72.144] (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s630.loopia.se (Postfix) with ESMTPSA id 4BCC113B948E; Fri, 20 Aug 2021 20:27:33 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: pgsql: psql: Add test for query canceling From: Daniel Gustafsson In-Reply-To: Date: Fri, 20 Aug 2021 20:27:32 +0200 Cc: Peter Eisentraut , pgsql-committers@lists.postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: <5F16EBAA-30D3-4C0D-840C-C2FF2739E370@yesql.se> References: To: Fabien COELHO X-Mailer: Apple Mail (2.3608.120.23.2.7) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 20 Aug 2021, at 17:40, Fabien COELHO wrote: >=20 >=20 >>> psql: Add test for query canceling >>=20 >> Seems sidewinder didn=E2=80=99t quite like this: >=20 >> Nothing obvious sticks out, could it be timing related? >=20 > Hmmm. Possibly, as the test is time dependent, hence the "SKIP:" = section, which should mean that the test should be ignore when it fails. = It seems that this part did not work. Maybe it should not state that it = is expecting 2 results? >=20 > use Test::More tests =3D> 2; >=20 > Replace by: >=20 > use Test::More; >=20 > Or something is amiss with the "SKIP" section trick? SKIP blocks only skip tests if the condition is met, in the test as it = stands now it skips it on Windows since it requires a Unix shell: +SKIP: { + skip "cancel test requires a Unix shell", 2 if $windows_os; On all other platforms the test will execute and count towards the = overall test result of the suite. If we want the test to run but not fail the entire test suite if it = fails then it should use a TODO block instead, but that=E2=80=99s intended for = tests known to fail and this doesn=E2=80=99t seem to fall in that category. -- Daniel Gustafsson https://vmware.com/