Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmyhJ-0006Yt-Qs for pgsql-committers@arkaria.postgresql.org; Fri, 06 May 2022 14:12:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyhI-0005Sd-O3 for pgsql-committers@arkaria.postgresql.org; Fri, 06 May 2022 14:12:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmyhI-0005SN-HH for pgsql-committers@lists.postgresql.org; Fri, 06 May 2022 14:12:44 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmyhG-0003AC-4S for pgsql-committers@lists.postgresql.org; Fri, 06 May 2022 14:12:44 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 69C9B60014; Fri, 6 May 2022 14:12:37 +0000 (UTC) Message-ID: <5be02606-a9de-9252-5277-269cae0ad1f0@dunslane.net> Date: Fri, 6 May 2022 10:12:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Content-Language: en-US To: Michael Paquier Cc: pgsql-committers@lists.postgresql.org References: <14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net> <12a044c9-e982-48d9-dd29-be1216a08805@dunslane.net> From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-05-02 Mo 03:06, Michael Paquier wrote: > On Sun, May 01, 2022 at 10:18:37AM -0400, Andrew Dunstan wrote: >> IIRC we know that tar will be available on Windows. > What about gzip? Are the binaries and the libraries split into > different packages for this package manager on Windows? We've never > assumed that this is possible on ./configure, but it would make sense > to make MSVC able to manage this case. vcpkg doesn't install any.exe files AFAICS, just DLLs, headers, .lib files etc. > >> I don't think we should do that check for every time we call >> vc_regress.pl, that seems wasteful. Maybe do it if the command is one >> that might require these commands, which I think would be bincheck or >> taptest. And/Or stash some status somewhere? > Mostly. We also care about gzip in contrib/basebackup_to_shell/, > though contribcheck does not run the TAP tests of contrib/ modules. > As you say, setting up those variables in bincheck and taptest would > be enough. That would be a start. Maybe meson will us get rid of some of this mess ... cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com