Content-Type: multipart/mixed; boundary="------------OeK6K9dzy90gals121h1Bu0W"
Message-ID: <5ed7d3e2-ca7e-40ad-9de9-e7648576cc01@postgrespro.ru>
Date: Thu, 25 Apr 2024 21:22:49 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: psql: add an optional execution-count limit to \watch.
To: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Alexander Korotkov <aekorotkov@gmail.com>,
 Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>,
 Aleksander Alekseev <aleksander@timescale.com>
References: <E1pkTFl-001hzA-LR@gemulon.postgresql.org>
 <CAPpHfdv+10Uk6FWjsh3+ju7kHYr76LaRXbYayXmrM7FBU-=Hgg@mail.gmail.com>
 <2929174.1680876023@sss.pgh.pa.us>
 <CAPpHfdtgQVRZOwov-Ei4Rh=gQtFE8Hb9uKkO1d_XYmQ2XEXt0g@mail.gmail.com>
 <CAJ7c6TO9KpYYxoVVseWEQB5KtjWDkt8NfyAeKPcHoe2Jq+ykpw@mail.gmail.com>
 <4032363.1681134882@sss.pgh.pa.us>
 <CAJ7c6TOFPoHVSxaQXfbm38_QN1v4qaugZW0LBTB-Gkvk2UwBQw@mail.gmail.com>
 <4076950.1681139381@sss.pgh.pa.us>
 <CAJ7c6TOVFT0bOEunovQAmZJDiLJ7Dds4YSONi4yOS1GYLvNntA@mail.gmail.com>
 <2748103.1681839252@sss.pgh.pa.us>
Content-Language: en-US
From: Anton Voloshin <a.voloshin@postgrespro.ru>
In-Reply-To: <2748103.1681839252@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/5ed7d3e2-ca7e-40ad-9de9-e7648576cc01%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------OeK6K9dzy90gals121h1Bu0W
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello, hackers.

On 18/04/2023 20:34, Tom Lane wrote (on pgsql-committers):
 > I shall now retire to a safe distance and watch the buildfarm.

Unfortunately, on fresh perl (5.38.2 verified) and on ru_RU.UTF-8 
locale, it breaks basic float comparison: 0 < 0.5 is no longer true.

This is the reproduction on REL_16_STABLE (but it affects master
as well), using fresh Ubuntu 24.04 container.

0. I've used lxc to get a fresh container:
$ lxc launch ubuntu-daily:noble u2404
But I don't think lxc or containerization in general matters in this 
case. Also, I think any environment with fresh enough Perl would work, 
Ubuntu 24.04 is just an easy example.

(obviously, install necessary dev packages)

1. Generate ru_RU.UTF-8 locale:
a. In /etc/locale.gen, uncomment the line:
# ru_RU.UTF-8 UTF-8

b. Run locale-gen as root. For me, it says:
$ sudo locale-gen
Generating locales (this might take a while)...
   en_US.UTF-8... done
   ru_RU.UTF-8... done
Generation complete.

2. Apply 0001-demo-of-weird-Perl-setlocale-effect-on-float-numbers.patch
(adding src/test/authentication/t/999_broken.pl)

3. Run the test
LANG=ru_RU.UTF-8 make check -C src/test/authentication 
PROVE_TESTS=t/999_broken.pl PROVE_FLAGS=--verbose

The test is, basically:
use PostgreSQL::Test::Utils;
use Test::More tests => 1;
ok(0 < 0.5, "0 < 0.5");

If I comment-out the "use PostgreSQL::Test::Utils" line, the test works. 
Otherwise it fails to notice that 0 is less than 0.5.

Alternatively, the test fails if I replace that "use" line with
BEGIN {
	use POSIX qw(locale_h);
	setlocale(LC_NUMERIC, "");
}

"BEGIN" part is essential: mere use/setlocale is fine.

Also, adding
use locale;
or even
use locale ':numeric';
fixes the test, but I doubt whether it's a good idea to add that to 
Utils.pm.

Obviously, one of the reasons is that according to ru_RU.UTF-8 locale 
for LC_NUMERIC, fractional part separator is ",", not ".". So one could, 
technically, parse "0.5" as "0" and then unparsed ".5" tail. I think it 
might even be a Perl bug, because, according to my quick browsing of man 
perlfunc (setlocale) and man perllocale, this should not affect the code 
outside "use locale", not in such a fundamental way. After all, we're 
talking not about strtod etc, but about floating-point numbers in the 
source code.

P.S. $ perl --version

This is perl 5, version 38, subversion 2 (v5.38.2) built for 
x86_64-linux-gnu-thread-multi
(with 44 registered patches, see perl -V for more detail)

P.P.S. I'm replying to pgsql-hackers, even though part of previous 
discussion have been on pgsql-committers. Hopefully, it's OK.

-- 
Anton Voloshin
Postgres Professional, The Russian Postgres Company
https://postgrespro.ru
--------------OeK6K9dzy90gals121h1Bu0W
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-demo-of-weird-Perl-setlocale-effect-on-float-numbers.patch"
Content-Disposition: attachment;
 filename*0="0001-demo-of-weird-Perl-setlocale-effect-on-float-numbers.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA2ZDE3MTlkZTQ5YjFjNjkwZTFmYjdhZWVkOGZjNzYwZjA1M2EyYTMxIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbiBWb2xvc2hpbiA8YS52b2xvc2hpbkBwb3N0
Z3Jlc3Byby5ydT4KRGF0ZTogVGh1LCAyNSBBcHIgMjAyNCAxNzoyMzoyNiArMDAwMApTdWJq
ZWN0OiBbUEFUQ0hdIGRlbW8gb2Ygd2VpcmQgUGVybCBzZXRsb2NhbGUgZWZmZWN0IG9uIGZs
b2F0IG51bWJlcnMKIGNvbXBhcmlzb24KCi0tLQogc3JjL3Rlc3QvYXV0aGVudGljYXRpb24v
dC85OTlfYnJva2VuLnBsIHwgOCArKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0
aW9ucygrKQogY3JlYXRlIG1vZGUgMTAwNjQ0IHNyYy90ZXN0L2F1dGhlbnRpY2F0aW9uL3Qv
OTk5X2Jyb2tlbi5wbAoKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L2F1dGhlbnRpY2F0aW9uL3Qv
OTk5X2Jyb2tlbi5wbCBiL3NyYy90ZXN0L2F1dGhlbnRpY2F0aW9uL3QvOTk5X2Jyb2tlbi5w
bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uZTY1YTI3MmUxY2IK
LS0tIC9kZXYvbnVsbAorKysgYi9zcmMvdGVzdC9hdXRoZW50aWNhdGlvbi90Lzk5OV9icm9r
ZW4ucGwKQEAgLTAsMCArMSw4IEBACit1c2Ugc3RyaWN0OwordXNlIHdhcm5pbmdzIEZBVEFM
ID0+ICdhbGwnOworCit1c2UgUG9zdGdyZVNRTDo6VGVzdDo6VXRpbHM7CisKK3VzZSBUZXN0
OjpNb3JlIHRlc3RzID0+IDE7CisKK29rKDAgPCAwLjUsICIwIDwgMC41Iik7Ci0tIAoyLjQz
LjAKCg==

--------------OeK6K9dzy90gals121h1Bu0W--