Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ruAER-0034Xw-LY for pgsql-committers@arkaria.postgresql.org; Tue, 09 Apr 2024 12:05:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ruAEQ-0045wY-HI for pgsql-committers@arkaria.postgresql.org; Tue, 09 Apr 2024 12:05:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ruAEO-0045wQ-Ou for pgsql-committers@lists.postgresql.org; Tue, 09 Apr 2024 12:05:42 +0000 Received: from wfout1-smtp.messagingengine.com ([64.147.123.144]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ruAEK-0020Fg-Tc for pgsql-committers@lists.postgresql.org; Tue, 09 Apr 2024 12:05:39 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.west.internal (Postfix) with ESMTP id 652BA1C000F8; Tue, 9 Apr 2024 08:05:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 09 Apr 2024 08:05:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1712664333; x=1712750733; bh=nUbiii5Zzf09Ff8NAPKMjcRqk0uSpiFunTJJaGuKg44=; b= VZAT4F+aMUsAOlHrxa2NYgvtWkezsZo59OT66qtsry+fOxtbfoUjOXlDkaLv1Hl+ agJkiWSzqRFKX70mstDVrAVytLqYNo8OcvstX3CdxtlsW8FLtm8Z0xsVjJM/sMNd CZ+kWEgUXbCFudaFHcv1m+Ayf2QoRujuk+regKHc8bGsqU2xWZXNoEd/yXBusNLH XrtnBZA9mvOuOc2EYucyxHX5OoUvKbaFMVeFBQ4/yJ/BS0H7REmmTY1bSze2zyBU MfuZksbLXmnmCvSiVAAzsS7JwtAe/gscqWTpGtQ/ybfI446cO8GeREKrrun/9riF O82kaTMQJqMRNM4sWUXkTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712664333; x= 1712750733; bh=nUbiii5Zzf09Ff8NAPKMjcRqk0uSpiFunTJJaGuKg44=; b=g r3gbIngkZ/cP/xqnkaSjNgu2akb0FbpmiyKeCJh3qwHxpGg+JwJ2LNT2xzHe9zHX wqt8dRQ4KEDQ1Spl3u92Oy5kpzVLF5GFHxIhJ1LEK6BZjHncZAM5VVU8V7X8o885 9oMzZxpgWagbLhTtlZrsVsdP4c7zI3dTaVOMggKMwXw0g5pmbczDV3Z8wXDeXrKL KvnS8F8uT09/FhLIDZ9VZCtKlKA3cgelVDo/Mj5d8wrkyKelD/lrSbjS5CjhzHw1 jLCD+9jmrV9BJhTD+KpzjM0dk/UNgI3slMbH3Jd/Wa0g2FKaQWkOLXnbuf7fjHFS L/GnCS8sj0ZVXNzMeMu/g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehtddgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttddvjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhgqe enucggtffrrghtthgvrhhnpeehiedvhfeuhfeugefgfeehgeejtdevuefhtefhueefvddu gfdtueehgfefudfhffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgh X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 9 Apr 2024 08:05:32 -0400 (EDT) Message-ID: <5f724fb2-96e1-4f36-b65b-47b337ad432e@eisentraut.org> Date: Tue, 9 Apr 2024 14:05:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Introduce a bump memory allocator To: David Rowley , pgsql-committers@lists.postgresql.org References: Content-Language: en-US From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 07.04.24 14:03, David Rowley wrote: > Introduce a bump memory allocator This patch introduces in bump.c the macro BumpBlockIsValid(), but it's not used anywhere. Can we remove it? (If we don't remove it, I suggest to make it an inline function, so it's easier to tell what it's supposed to be called with. Especially with the BumpIsValid() nearby, it can be a bit confusing.)