Message-ID: <5ff5239e-b5b2-6874-9667-e927ec55f1db@dunslane.net>
Date: Thu, 13 Jan 2022 12:01:08 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: pgsql: Check for STATUS_DELETE_PENDING on Windows.
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>,
 Thomas Munro <tmunro@postgresql.org>,
 pgsql-committers <pgsql-committers@lists.postgresql.org>
References: <E1mvWTz-0006Hc-Dn@gemulon.postgresql.org>
 <2760528.1641929756@sss.pgh.pa.us>
 <CA+hUKGLpuR87F7s7GCkCn9Qs0GMyLJYvRYxf_zQJPw==t+uE0g@mail.gmail.com>
 <8320cca6-5647-be5d-9b22-914415bcbc27@dunslane.net>
 <2801180.1641938050@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <2801180.1641938050@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/5ff5239e-b5b2-6874-9667-e927ec55f1db%40dunslane.net>
Precedence: bulk


On 1/11/22 16:54, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> On 1/11/22 16:22, Thomas Munro wrote:
>>> Those scripts aren't really on my radar... would it be a good idea to
>>> run them as steps in the CompilerWarnings CI task?
>> Or in a buildfarm module (c.f. the perl checks)
> +1 for one or the other, because we break that regularly and it
> typically takes awhile to notice.
>
> 			


Done See
<https://github.com/PGBuildFarm/client-code/commit/51a6f79ec16de87a7eba7a66015985998311d465>


crake will now run this as part of its normal runs on HEAD.


cheers


andew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com