Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjU6u-00019Q-Ew for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 22:24:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mjU6t-0007Fq-8H for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 22:24:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjU6t-0007Fh-1H for pgsql-committers@lists.postgresql.org; Sat, 06 Nov 2021 22:24:27 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjU6q-0006Sm-JR for pgsql-committers@lists.postgresql.org; Sat, 06 Nov 2021 22:24:26 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1A6MOLDY612843; Sat, 6 Nov 2021 18:24:21 -0400 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster. In-reply-to: References: Comments: In-reply-to Andres Freund message dated "Mon, 04 Oct 2021 20:16:51 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <612841.1636237461.1@sss.pgh.pa.us> Date: Sat, 06 Nov 2021 18:24:21 -0400 Message-ID: <612842.1636237461@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > windows: Define WIN32_LEAN_AND_MEAN to make compilation faster. I happened to notice from grepping that src/backend/port/win32/crashdump.c has its own #define WIN32_LEAN_AND_MEAN Can't we remove that now? (I kind of wonder what good it did at all, considering postgres.h has already pulled in .) regards, tom lane