Feedback-ID: ie0a040ee:Fastmail
Content-Type: multipart/mixed; boundary="------------G0f9jdoKNpO6lbmIX3Lzzcaw"
Message-ID: <61be9e31-7b7d-49d5-bc11-721800d89d64@eisentraut.org>
Date: Tue, 8 Apr 2025 19:06:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Make cancel request keys longer
To: Heikki Linnakangas <heikki.linnakangas@iki.fi>,
 pgsql-committers@lists.postgresql.org
References: <E1tzyNB-002IXa-0i@gemulon.postgresql.org>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <E1tzyNB-002IXa-0i@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/61be9e31-7b7d-49d5-bc11-721800d89d64%40eisentraut.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------G0f9jdoKNpO6lbmIX3Lzzcaw
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 02.04.25 15:43, Heikki Linnakangas wrote:
> Make cancel request keys longer

This patch changed the signature of ProcSignal()

-ProcSignalInit(bool cancel_key_valid, int32 cancel_key)
+ProcSignalInit(char *cancel_key, int cancel_key_len)

but did not update the caller in auxprocess.c:

ProcSignalInit(false, 0);

This gives a warning with clang.

While I was looking at this, I suggest to make the first argument void 
*.  This is consistent for passing binary data.

Also, I wonder why MyCancelKeyLength is of type uint8 rather than 
something more mundane like int.  There doesn't seem to be any API 
reason for this type.

See attached patch for possible changes.
--------------G0f9jdoKNpO6lbmIX3Lzzcaw
Content-Type: text/plain; charset=UTF-8;
 name="0001-WIP-Fix-cancel-key-stuff.patch"
Content-Disposition: attachment;
 filename="0001-WIP-Fix-cancel-key-stuff.patch"
Content-Transfer-Encoding: base64

RnJvbSA4YWJlNmU2NjUyMWRlN2ZlNWQyMTMyZmQ1NDcxMjY1ZWYxYmY2YjBlIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogVHVlLCA4IEFwciAyMDI1IDE5OjAxOjI5ICswMjAwClN1YmplY3Q6
IFtQQVRDSF0gV0lQOiBGaXggY2FuY2VsIGtleSBzdHVmZgoKLS0tCiBzcmMvYmFja2VuZC9w
b3N0bWFzdGVyL2F1eHByb2Nlc3MuYyAgfCAyICstCiBzcmMvYmFja2VuZC9zdG9yYWdlL2lw
Yy9wcm9jc2lnbmFsLmMgfCAyICstCiBzcmMvYmFja2VuZC91dGlscy9pbml0L2dsb2JhbHMu
YyAgICAgfCAyICstCiBzcmMvaW5jbHVkZS9taXNjYWRtaW4uaCAgICAgICAgICAgICAgfCAy
ICstCiBzcmMvaW5jbHVkZS9zdG9yYWdlL3Byb2NzaWduYWwuaCAgICAgfCAyICstCiA1IGZp
bGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL2F1eHByb2Nlc3MuYyBiL3NyYy9iYWNrZW5k
L3Bvc3RtYXN0ZXIvYXV4cHJvY2Vzcy5jCmluZGV4IDRmNjc5NWY3MjY1Li5hNmQzNjMwMzk4
ZiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9hdXhwcm9jZXNzLmMKKysr
IGIvc3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9hdXhwcm9jZXNzLmMKQEAgLTY2LDcgKzY2LDcg
QEAgQXV4aWxpYXJ5UHJvY2Vzc01haW5Db21tb24odm9pZCkKIAogCUJhc2VJbml0KCk7CiAK
LQlQcm9jU2lnbmFsSW5pdChmYWxzZSwgMCk7CisJUHJvY1NpZ25hbEluaXQoTlVMTCwgMCk7
CiAKIAkvKgogCSAqIEF1eGlsaWFyeSBwcm9jZXNzZXMgZG9uJ3QgcnVuIHRyYW5zYWN0aW9u
cywgYnV0IHRoZXkgbWF5IG5lZWQgYQpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvc3RvcmFn
ZS9pcGMvcHJvY3NpZ25hbC5jIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9pcGMvcHJvY3NpZ25h
bC5jCmluZGV4IGEzYzJjZDEyMjc3Li4zM2IxYTViZTI3NiAxMDA2NDQKLS0tIGEvc3JjL2Jh
Y2tlbmQvc3RvcmFnZS9pcGMvcHJvY3NpZ25hbC5jCisrKyBiL3NyYy9iYWNrZW5kL3N0b3Jh
Z2UvaXBjL3Byb2NzaWduYWwuYwpAQCAtMTYyLDcgKzE2Miw3IEBAIFByb2NTaWduYWxTaG1l
bUluaXQodm9pZCkKICAqCQlSZWdpc3RlciB0aGUgY3VycmVudCBwcm9jZXNzIGluIHRoZSBQ
cm9jU2lnbmFsIGFycmF5CiAgKi8KIHZvaWQKLVByb2NTaWduYWxJbml0KGNoYXIgKmNhbmNl
bF9rZXksIGludCBjYW5jZWxfa2V5X2xlbikKK1Byb2NTaWduYWxJbml0KGNvbnN0IHZvaWQg
KmNhbmNlbF9rZXksIGludCBjYW5jZWxfa2V5X2xlbikKIHsKIAlQcm9jU2lnbmFsU2xvdCAq
c2xvdDsKIAl1aW50NjQJCWJhcnJpZXJfZ2VuZXJhdGlvbjsKZGlmZiAtLWdpdCBhL3NyYy9i
YWNrZW5kL3V0aWxzL2luaXQvZ2xvYmFscy5jIGIvc3JjL2JhY2tlbmQvdXRpbHMvaW5pdC9n
bG9iYWxzLmMKaW5kZXggOTIzMDRhMWYxMjQuLjE4NDdlN2M4NWQzIDEwMDY0NAotLS0gYS9z
cmMvYmFja2VuZC91dGlscy9pbml0L2dsb2JhbHMuYworKysgYi9zcmMvYmFja2VuZC91dGls
cy9pbml0L2dsb2JhbHMuYwpAQCAtNTEsNyArNTEsNyBAQCBUaW1lc3RhbXBUeiBNeVN0YXJ0
VGltZXN0YW1wOwogc3RydWN0IENsaWVudFNvY2tldCAqTXlDbGllbnRTb2NrZXQ7CiBzdHJ1
Y3QgUG9ydCAqTXlQcm9jUG9ydDsKIGNoYXIJCU15Q2FuY2VsS2V5W01BWF9DQU5DRUxfS0VZ
X0xFTkdUSF07Ci11aW50OAkJTXlDYW5jZWxLZXlMZW5ndGggPSAwOworaW50CQkJTXlDYW5j
ZWxLZXlMZW5ndGggPSAwOwogaW50CQkJTXlQTUNoaWxkU2xvdDsKIAogLyoKZGlmZiAtLWdp
dCBhL3NyYy9pbmNsdWRlL21pc2NhZG1pbi5oIGIvc3JjL2luY2x1ZGUvbWlzY2FkbWluLmgK
aW5kZXggNThiMjQ5NmE5Y2IuLjcyZjU2NTVmYjM0IDEwMDY0NAotLS0gYS9zcmMvaW5jbHVk
ZS9taXNjYWRtaW4uaAorKysgYi9zcmMvaW5jbHVkZS9taXNjYWRtaW4uaApAQCAtMTkzLDcg
KzE5Myw3IEBAIGV4dGVybiBQR0RMTElNUE9SVCBUaW1lc3RhbXBUeiBNeVN0YXJ0VGltZXN0
YW1wOwogZXh0ZXJuIFBHRExMSU1QT1JUIHN0cnVjdCBQb3J0ICpNeVByb2NQb3J0OwogZXh0
ZXJuIFBHRExMSU1QT1JUIHN0cnVjdCBMYXRjaCAqTXlMYXRjaDsKIGV4dGVybiBQR0RMTElN
UE9SVCBjaGFyIE15Q2FuY2VsS2V5W107Ci1leHRlcm4gUEdETExJTVBPUlQgdWludDggTXlD
YW5jZWxLZXlMZW5ndGg7CitleHRlcm4gUEdETExJTVBPUlQgaW50IE15Q2FuY2VsS2V5TGVu
Z3RoOwogZXh0ZXJuIFBHRExMSU1QT1JUIGludCBNeVBNQ2hpbGRTbG90OwogCiBleHRlcm4g
UEdETExJTVBPUlQgY2hhciBPdXRwdXRGaWxlTmFtZVtdOwpkaWZmIC0tZ2l0IGEvc3JjL2lu
Y2x1ZGUvc3RvcmFnZS9wcm9jc2lnbmFsLmggYi9zcmMvaW5jbHVkZS9zdG9yYWdlL3Byb2Nz
aWduYWwuaAppbmRleCBjZmUxNDYzMTQ0NS4uMDgxMDhhNWQ3ZGUgMTAwNjQ0Ci0tLSBhL3Ny
Yy9pbmNsdWRlL3N0b3JhZ2UvcHJvY3NpZ25hbC5oCisrKyBiL3NyYy9pbmNsdWRlL3N0b3Jh
Z2UvcHJvY3NpZ25hbC5oCkBAIC03Myw3ICs3Myw3IEBAIHR5cGVkZWYgZW51bQogZXh0ZXJu
IFNpemUgUHJvY1NpZ25hbFNobWVtU2l6ZSh2b2lkKTsKIGV4dGVybiB2b2lkIFByb2NTaWdu
YWxTaG1lbUluaXQodm9pZCk7CiAKLWV4dGVybiB2b2lkIFByb2NTaWduYWxJbml0KGNoYXIg
KmNhbmNlbF9rZXksIGludCBjYW5jZWxfa2V5X2xlbik7CitleHRlcm4gdm9pZCBQcm9jU2ln
bmFsSW5pdChjb25zdCB2b2lkICpjYW5jZWxfa2V5LCBpbnQgY2FuY2VsX2tleV9sZW4pOwog
ZXh0ZXJuIGludAlTZW5kUHJvY1NpZ25hbChwaWRfdCBwaWQsIFByb2NTaWduYWxSZWFzb24g
cmVhc29uLAogCQkJCQkJICAgUHJvY051bWJlciBwcm9jTnVtYmVyKTsKIGV4dGVybiB2b2lk
IFNlbmRDYW5jZWxSZXF1ZXN0KGludCBiYWNrZW5kUElELCBjaGFyICpjYW5jZWxfa2V5LCBp
bnQgY2FuY2VsX2tleV9sZW4pOwotLSAKMi40OS4wCgo=

--------------G0f9jdoKNpO6lbmIX3Lzzcaw--