public inbox for [email protected]  
help / color / mirror / Atom feed
pgsql: Cleanup comments/docs around the new shmem request callbacks
4+ messages / 3 participants
[nested] [flat]

* pgsql: Cleanup comments/docs around the new shmem request callbacks
@ 2026-07-07 19:40  Heikki Linnakangas <[email protected]>
  0 siblings, 0 replies; 4+ messages in thread

From: Heikki Linnakangas @ 2026-07-07 19:40 UTC (permalink / raw)
  To: [email protected]

Cleanup comments/docs around the new shmem request callbacks

Make it explicit in the docs that the shmem initialization callbacks
are called while holding ShmemIndexLock.

Reviewed-by: Ashutosh Bapat <[email protected]>
Discussion: https://www.postgresql.org/message-id/[email protected]...
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6f7199a1245cab986a13c7b57812255fe77679d1

Modified Files
--------------
doc/src/sgml/xfunc.sgml         | 4 ++--
src/backend/storage/ipc/shmem.c | 7 +++++--
2 files changed, 7 insertions(+), 4 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Cleanup comments/docs around the new shmem request callbacks
@ 2026-07-07 19:40  Heikki Linnakangas <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Heikki Linnakangas @ 2026-07-07 19:40 UTC (permalink / raw)
  To: [email protected]

Cleanup comments/docs around the new shmem request callbacks

Make it explicit in the docs that the shmem initialization callbacks
are called while holding ShmemIndexLock.

Reviewed-by: Ashutosh Bapat <[email protected]>
Discussion: https://www.postgresql.org/message-id/[email protected]...
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a53d6d8aea8fe703d86dd2bdc0a3d86800eca7c3

Modified Files
--------------
doc/src/sgml/xfunc.sgml         | 4 ++--
src/backend/storage/ipc/shmem.c | 7 +++++--
2 files changed, 7 insertions(+), 4 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Cleanup comments/docs around the new shmem request callbacks
@ 2026-07-08 02:26  Erik Rijkers <[email protected]>
  parent: Heikki Linnakangas <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Erik Rijkers @ 2026-07-08 02:26 UTC (permalink / raw)
  To: Heikki Linnakangas <[email protected]>; PostgreSQL Hackers <[email protected]>

Op 7/7/26 om 21:40 schreef Heikki Linnakangas:
> Cleanup comments/docs around the new shmem request callbacks
> 
> Make it explicit in the docs that the shmem initialization callbacks
> are called while holding ShmemIndexLock.
> 
> Reviewed-by: Ashutosh Bapat <[email protected]>
> Discussion: https://www.postgresql.org/message-id/[email protected]...
> Backpatch-through: 19
> 
> Branch
> ------
> REL_19_STABLE
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/a53d6d8aea8fe703d86dd2bdc0a3d86800eca7c3
> 
> Modified Files
> --------------
> doc/src/sgml/xfunc.sgml         | 4 ++--

Hi,

in doc/src/sgml/xfunc.sgml

the sentence:
   "two backends trying to initializing the memory area"

should be:
   "two backends trying to initialize the memory area"

Thanks,


Erik


> src/backend/storage/ipc/shmem.c | 7 +++++--
> 2 files changed, 7 insertions(+), 4 deletions(-)
> 





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Cleanup comments/docs around the new shmem request callbacks
@ 2026-07-08 07:25  Heikki Linnakangas <[email protected]>
  parent: Erik Rijkers <[email protected]>
  0 siblings, 0 replies; 4+ messages in thread

From: Heikki Linnakangas @ 2026-07-08 07:25 UTC (permalink / raw)
  To: Erik Rijkers <[email protected]>; PostgreSQL Hackers <[email protected]>

On 08/07/2026 05:26, Erik Rijkers wrote:
> in doc/src/sgml/xfunc.sgml
> 
> the sentence:
>    "two backends trying to initializing the memory area"
> 
> should be:
>    "two backends trying to initialize the memory area"

Fixed, thanks!

- Heikki







^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2026-07-08 07:25 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-07 19:40 pgsql: Cleanup comments/docs around the new shmem request callbacks Heikki Linnakangas <[email protected]>
2026-07-07 19:40 pgsql: Cleanup comments/docs around the new shmem request callbacks Heikki Linnakangas <[email protected]>
2026-07-08 02:26 ` Erik Rijkers <[email protected]>
2026-07-08 07:25   ` Heikki Linnakangas <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox