Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZxvI-00084H-Ay for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Mar 2022 16:45:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZxvH-0000F1-9S for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Mar 2022 16:45:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZxvH-0000Cg-0O for pgsql-hackers@lists.postgresql.org; Thu, 31 Mar 2022 16:45:23 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZxvE-0005AV-MV for pgsql-hackers@lists.postgresql.org; Thu, 31 Mar 2022 16:45:21 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22VGjDOa648072; Thu, 31 Mar 2022 12:45:13 -0400 From: Tom Lane To: Robert Haas cc: Andrew Dunstan , Nathan Bossart , Andres Freund , Thomas Munro , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. In-reply-to: References: <20220329222504.aylyimyub6igsvpy@alap3.anarazel.de> <684ed71e-0876-60c0-8e44-066ba702f0a6@dunslane.net> <20220330163024.fsbpbxwxh5oo2ktx@alap3.anarazel.de> <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de> <285252.1648671723@sss.pgh.pa.us> <20220330223531.GA134543@nathanxps13> <472639.1648684865@sss.pgh.pa.us> <485495.1648692468@sss.pgh.pa.us> <639823.1648740735@sss.pgh.pa.us> <61e2e2c0-1b1c-3b48-4d5c-2fe581e63121@dunslane.net> Comments: In-reply-to Robert Haas message dated "Thu, 31 Mar 2022 12:30:08 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <648070.1648745113.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 31 Mar 2022 12:45:13 -0400 Message-ID: <648071.1648745113@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Robert Haas writes: > On Thu, Mar 31, 2022 at 12:25 PM Andrew Dunstan wr= ote: >> Yeah, I think the fix is as simple as the attached. > Well, that does not work because you added an extra parenthesis which > makes Perl barf. If you fix that, then the test does not pass because, > as I just explained to Tom, the flag we call --create-role doesn't > create a role: > error running SQL: 'psql::1: ERROR: role "backupuser" does not e= xist' On looking closer, the combination of --config-auth and --create-role *only* fixes the config files for SSPI, it doesn't expect the server to be running. I agree that the documentation of this is nonexistent and the design is probably questionable, but I'm not volunteering to fix either. If you are, step right up. In the meantime, I believe (without having tested) that the correct incantation is to use auth_extra but *also* create the user further down. regards, tom lane