Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZy0U-0008Kn-B3 for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 16:50:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZy0T-0003Xw-14 for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 16:50:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZy0S-0003Xm-QR for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 16:50:44 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZy0Q-0005Cj-J7 for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 16:50:43 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22VGofFv648534; Thu, 31 Mar 2022 12:50:41 -0400 From: Tom Lane To: Andrew Dunstan cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches In-reply-to: <230c42b8-5758-3616-b4fd-df9191f0c273@dunslane.net> References: <474104.1648685981@sss.pgh.pa.us> <393B4FCB-1A6D-4993-B914-7E20A54863BE@dunslane.net> <479467.1648689140@sss.pgh.pa.us> <230c42b8-5758-3616-b4fd-df9191f0c273@dunslane.net> Comments: In-reply-to Andrew Dunstan message dated "Thu, 31 Mar 2022 06:09:34 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <648532.1648745441.1@sss.pgh.pa.us> Date: Thu, 31 Mar 2022 12:50:41 -0400 Message-ID: <648533.1648745441@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > There are three ways out of this that I can see: > . carry a copy of parent.pm in src/test/perl (It's very small) > . use the older and heavier 'base' module which goes back to 5.004, and > does much the same thing (and a lot more) > . just do directly what parent.pm's import() does, as in the attached, > which I have tested down to version 10. > On the whole I think I prefer the last. I like #3 too, given that it's such a small patch. I've verified that it allows regression tests to run on perl 5.8.8, which is the oldest I have handy other than prairiedog's 5.8.3 (but that machine is tied up and I don't feel like trying to test this concurrently with a buildfarm run). regards, tom lane