Message-ID: <64e8ec11-6bb8-488b-abfc-8e67324a03fa@vondra.me>
Date: Tue, 1 Jul 2025 13:03:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Introduce pg_shmem_allocations_numa view
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Christoph Berg <myon@debian.org>, Andres Freund <andres@anarazel.de>,
 Tomas Vondra <tomas.vondra@postgresql.org>,
 pgsql-hackers@lists.postgresql.org
References: <b54df21b-6595-4031-baf8-7c87851794c8@vondra.me>
 <aFuRoUieUVh+pMfZ@ip-10-97-1-34.eu-west-3.compute.internal>
 <aFu6tmQ7EVaaNV9K@msg.df7cb.de>
 <aFzadttaX+Qnb5s3@ip-10-97-1-34.eu-west-3.compute.internal>
 <aed7fd1f-4691-45d6-a002-6eba297443ca@vondra.me>
 <aF7V5hLDOc54QKfP@ip-10-97-1-34.eu-west-3.compute.internal>
 <132f85de-75c8-4e21-b875-b806596c9214@vondra.me>
 <aGNex9zyxmXqCHXy@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Language: en-US
From: Tomas Vondra <tomas@vondra.me>
In-Reply-To: <aGNex9zyxmXqCHXy@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/64e8ec11-6bb8-488b-abfc-8e67324a03fa%40vondra.me>
Precedence: bulk


On 7/1/25 06:06, Bertrand Drouvot wrote:
> Hi,
> 
> On Mon, Jun 30, 2025 at 08:56:43PM +0200, Tomas Vondra wrote:
>> In particular it now uses "chunking" instead of "batching". I believe
>> bathing is "combining multiple requests into a single one", but we're
>> doing exactly the opposite - splitting a large request into smaller
>> ones. Which is what "chunking" does.
> 
> I do agree that "chuncking" is more appropriate here.
> 
>> I plan to push this tomorrow morning.
> 
> Thanks!
> 
> LGTM, just 2 nit about the commit messages:
> 
> For 0001:
> 
> Is it worth to add a link to the Kernel Bug report or mentioned it can be
> found in the discussion?
> 
> For 0003:
> 
> "
> But with the chunking, introduced to work around the do_pages_stat()
> bug"
> 
> Do you have in mind to quote the hex commit object name that will be generated
> by 0001?
> 

Thanks! Pushed, with both adjustments (link to kernel thread, adding the
commit hash).

But damn it, right after pushing I noticed two typos in the second
commit message :-/

-- 
Tomas Vondra