Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUDyI-0005hi-RX for pgsql-committers@arkaria.postgresql.org; Tue, 15 Mar 2022 20:40:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nUDyG-00067w-UO for pgsql-committers@arkaria.postgresql.org; Tue, 15 Mar 2022 20:40:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUDyG-00067N-NV for pgsql-committers@lists.postgresql.org; Tue, 15 Mar 2022 20:40:44 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUDyD-00017d-Gb for pgsql-committers@lists.postgresql.org; Tue, 15 Mar 2022 20:40:44 +0000 Received: from [10.5.0.2] (unknown [89.187.175.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id 0949854668; Tue, 15 Mar 2022 20:40:38 +0000 (UTC) Message-ID: <66373991-e520-40c1-f1e8-c758c7b24cb7@pgmasters.net> Date: Tue, 15 Mar 2022 14:40:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: pgsql: Fix pg_basebackup with in-place tablespaces. Content-Language: en-US To: Thomas Munro , pgsql-committers@lists.postgresql.org References: From: David Steele In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/14/22 19:31, Thomas Munro wrote: > Fix pg_basebackup with in-place tablespaces. > > Previously, pg_basebackup from a cluster that contained an 'in-place' > tablespace, as introduced by commit 7170f215, would produce a harmless > warning on Unix and fail completely on Windows. Perhaps I'm being picky, but seems like this logic should be wrapped in: if (allow_in_place_tablespaces) { <...> } I worry about strange effects when this GUC is not enabled. Regards, -David