Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1eiXFn-000505-F5
	for pgsql-committers@arkaria.postgresql.org; Mon, 05 Feb 2018 03:15:35 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1eiXFm-00044C-HW
	for pgsql-committers@arkaria.postgresql.org; Mon, 05 Feb 2018 03:15:34 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eiXFm-00043x-9z
	for pgsql-committers@lists.postgresql.org; Mon, 05 Feb 2018 03:15:34 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eiXFj-00086l-Gk
	for pgsql-committers@postgresql.org; Mon, 05 Feb 2018 03:15:33 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w153FT6c006687;
	Sun, 4 Feb 2018 22:15:29 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
cc: pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Fix another instance of unsafe coding for shm_toc_lookup
 failure
In-reply-to: 
 <CAEepm=2sCOUoaEgvJqMXdJAzyc=1DYB2ENia4Ld4D7gA8yqREg@mail.gmail.com>
References: <E1ehkoZ-0005uW-43@gemulon.postgresql.org>
 <CAEepm=2afhhpgK+11xZWiApaJJ_P=624ZqZP_pM2JSuLVGxGxA@mail.gmail.com>
 <9324.1517623729@sss.pgh.pa.us>
 <CAEepm=2sCOUoaEgvJqMXdJAzyc=1DYB2ENia4Ld4D7gA8yqREg@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@enterprisedb.com>
	message dated "Mon, 05 Feb 2018 15:47:13 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6685.1517800529.1@sss.pgh.pa.us>
Date: Sun, 04 Feb 2018 22:15:29 -0500
Message-ID: <6686.1517800529@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Sat, Feb 3, 2018 at 3:08 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> OK.  Please send in a patch to either do that or switch this call to use
>> noError = false.  Or possibly both: shouldn't there be some other signal
>> path that tells the worker whether instrumentation is needed?  I'll
>> leave it alone pending your investigation.

> Here's a patch do to both.

LGTM, pushed.

			regards, tom lane