Content-Type: multipart/alternative;
 boundary="------------sFAFRZaNuA4jbVuwHXueWDcR"
Message-ID: <66b5b1d6-3f2a-4944-91a3-7e40a565ccac@dunslane.net>
Date: Sun, 15 Sep 2024 14:30:47 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings
To: Bruce Momjian <bruce@momjian.us>, pgsql-committers@lists.postgresql.org
References: <E1spqfS-001Ehn-Cx@gemulon.postgresql.org>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX
 gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC
 ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY
 xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm
 HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru
 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl
 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO
 E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa
 Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo
 nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S
 GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy
 xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b
 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx
 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/
 fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4
 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0
 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS
 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw
 49QYe1sn2ZPs
In-Reply-To: <E1spqfS-001Ehn-Cx@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/66b5b1d6-3f2a-4944-91a3-7e40a565ccac%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------sFAFRZaNuA4jbVuwHXueWDcR
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2024-09-15 Su 10:56 AM, Bruce Momjian wrote:
> Perl scripts:  eliminate "Useless interpolation" warnings
>
> Eliminate warnings of Perl Critic from src/tools.
>
> Backpatch-through: master


I don't understand this commit. The buildfarm members crake and koel 
regularly run the perl critic checks and have not complained. See for 
example from before this change: 
<https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=koel&dt=2024-09-15%2003%3A34%3A02&stg=perl-check>

The change doesn't seem to have had any discussion either. This 
particular warning is surely a very low level (i.e. fairly unimportant) 
one, of the type we normally ignore. If some version of perlcritic has 
raised it to severity 5 then the correct action IMNSHO would be to add 
an exception for it to the perlcriticrc, like we do for 
ProhibitLeadingZeros. If not, then perhaps you can explain how you got 
the warnings.


cheers


andrew


--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------sFAFRZaNuA4jbVuwHXueWDcR
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 2024-09-15 Su 10:56 AM, Bruce
      Momjian wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:E1spqfS-001Ehn-Cx@gemulon.postgresql.org">
      <pre class="moz-quote-pre" wrap="">Perl scripts:  eliminate "Useless interpolation" warnings

Eliminate warnings of Perl Critic from src/tools.

Backpatch-through: master</pre>
    </blockquote>
    <p><br>
    </p>
    <p><br>
    </p>
    <p>I don't understand this commit. The buildfarm members crake and
      koel regularly run the perl critic checks and have not complained.
      See for example from before this change:
<a class="moz-txt-link-rfc2396E" href="https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=koel&amp;dt=2024-09-15%2003%3A34%3A02&amp;stg=perl-check">&lt;https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=koel&amp;dt=2024-09-15%2003%3A34%3A02&amp;stg=perl-check&gt;</a><br>
    </p>
    <p>The change doesn't seem to have had any discussion either. This
      particular warning is surely a very low level (i.e. fairly
      unimportant) one, of the type we normally ignore. If some version
      of perlcritic has raised it to severity 5 then the correct action
      IMNSHO would be to add an exception for it to the perlcriticrc,
      like we do for ProhibitLeadingZeros. If not, then perhaps you can
      explain how you got the warnings.<br>
    </p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <p><br>
    </p>
    <p><br>
    </p>
    <p><span style="white-space: pre-wrap">
</span></p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------sFAFRZaNuA4jbVuwHXueWDcR--