Feedback-ID: i7c334307:Fastmail
Content-Type: multipart/signed;
	boundary="Apple-Mail=_82F9D052-4BE2-4A8D-99B5-6EAA14B56AAF";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\))
Subject: Re: extension_control_path and "directory"
From: "David E. Wheeler" <david@justatheory.com>
In-Reply-To: 
 <CAFY6G8fjaVpkZHFk3CQR=ShiysZ3Y_ti568-vuKYOrMepLB_sQ@mail.gmail.com>
Date: Fri, 25 Apr 2025 15:13:02 -0400
Cc: Christoph Berg <myon@debian.org>,
 Peter Eisentraut <peter@eisentraut.org>,
 pgsql-hackers@lists.postgresql.org
Message-Id: <672C8C5E-519A-4B39-9421-E6C31917B271@justatheory.com>
References: <E1tumbY-003Dl3-2o@gemulon.postgresql.org>
 <aAi1VACxhjMhjFnb@msg.df7cb.de>
 <CAFY6G8dDjimxaSQV68ExWMmrAi8xNhiOT3RZOD8oQZmdGCG5Jg@mail.gmail.com>
 <aAjwPjsIElh17Nby@msg.df7cb.de>
 <3C304C9E-976C-4FB9-A883-707E0B90756A@justatheory.com>
 <CAFY6G8c=W8CMFwcx2fA0RSFtvw=5BDGKOjGSV=nEUiZ6use2Bw@mail.gmail.com>
 <aAoQkqwktHQI5KLO@msg.df7cb.de>
 <CAFY6G8d-4Nb34dqb_92kGrXfo4tO012m-9YzznKmb7f5JhJpEA@mail.gmail.com>
 <546E7C54-D2F4-4DBB-9A06-EBBF90265A2C@justatheory.com>
 <CAFY6G8fjaVpkZHFk3CQR=ShiysZ3Y_ti568-vuKYOrMepLB_sQ@mail.gmail.com>
To: Matheus Alcantara <matheusssilv97@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/672C8C5E-519A-4B39-9421-E6C31917B271%40justatheory.com>
Precedence: bulk


--Apple-Mail=_82F9D052-4BE2-4A8D-99B5-6EAA14B56AAF
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On Apr 25, 2025, at 09:25, Matheus Alcantara <matheusssilv97@gmail.com> =
wrote:

> Yes, you are right. The problem was where I was asserting
> control->control_dir !=3D NULL. I've moved the assert after the "if
> (!filename)" check that returns an error if the extension was not =
found.
>=20
> Attached v3 with this fix and also a TAP test for this scenario.

That fixes the segfault, thank you.

> I'm just a bit confused how you get it working using /extension at the
> end of extension_control_path since with this patch this suffix is not
> necessary and since we hard coded append this it should return an =
error
> when trying to search on something like

It worked with

extension_control_path =3D =
'/Users/david/Downloads/share/postgresql/extension:$system=E2=80=99

But not with

extension_control_path =3D =
'/Users/david/Downloads/share/postgresql:$system=E2=80=99

And here is where the control file actually is:

=E2=9D=AF ll ~/Downloads/share/postgresql/extension  total 8
-rw-r--r--  1 david  staff   161B Apr 24 18:07 semver.control

So I don=E2=80=99t know the answer to your question, but it=E2=80=99d be =
handy to have functions that return a list of resolved paths from =
extension_control_path and dynamic_library_path, since they get mangled.

Best,

David


--Apple-Mail=_82F9D052-4BE2-4A8D-99B5-6EAA14B56AAF
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd+KfmbOQis6ZycGGkt9idPjIgfEFAmgL3r4ACgkQkt9idPjI
gfFBxQ/+M5HabgaS04RCAdECGOvA/zi23xQ6858gs1tXHiyn27MPMUjFNrC/hcg/
8uH1ptK0U9xVUZVTqhq5X2KYGU7PWkkDLLQ2RzrhK00iupZZ0orVhLg8oYxL0TlK
sWkz1I8DalRSDqM59kT1oKm6VlK/+gbglqINAEKO3oykRroAVZqCOzd9w96T4hSV
TjpkdhjP1fqG6YKbF6A+Ax1qqjRdDaDStmV+fWVpHvCVf1K8ZJG1Dx1A2j7sC6TM
GcT4Psye+ABJWTub/gqv9yUbyh3DADafIerxznnrfK1GvFrUlNzaSzsqnU7GwVdO
BEWvJ0oG0dGdggF0VPXj4pmRBAZUf17QV/v9jarMiZgxomeaFp3ju9gckQN/hajD
bcFdFNEYLQ2sXBJqMjUa26QjvaFobBxMHS1h0PnjpzoHvsbFhB3D+na9BjOteuer
vT7OJOsgY34WE3V8Ia8a3d3Gu57gwZUx0fvY0hhAEcMLt/3uOREvDK/mblzthbFV
huJqvjoGzMPTGczTd73dszcenS3g0o8R1ipJK4zPLh3Kt4WkCXySeVBOhrSHAUCa
CJmo8kdyaE3aXXgevyBH4u3PlGYKHu0CrhOynB/owdiqM5Bm2aD7bsvBF2Ocne0Q
k1V4+p9Lkm8qpOT1zKDB4wyeYp0kWluE5ss9VLjiUOgjwPbifSA=
=unWE
-----END PGP SIGNATURE-----

--Apple-Mail=_82F9D052-4BE2-4A8D-99B5-6EAA14B56AAF--