From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: pgsql: Support arrays over domains.
To: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-committers@postgresql.org
References: <E1dyLlE-0002gT-H5@gemulon.postgresql.org>
Message-ID: <678e49f8-e32a-9b96-8e3f-a8c63d2f0e18@2ndQuadrant.com>
Date: Sat, 30 Sep 2017 15:19:05 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <E1dyLlE-0002gT-H5@gemulon.postgresql.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-MW
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org


On 09/30/2017 01:41 PM, Tom Lane wrote:
> Support arrays over domains.


We seem to have caused a problem with pg_upgrade :-(

The failing log file is:

    command: "/home/bf/bfr/root/upgrade/HEAD/inst/bin/pg_restore" --host
    /home/bf/bfr/root/upgrade/HEAD/inst --port 5648 --username buildfarm
    --exit-on-error --verbose --dbname
    'dbname=contrib_regression_hstore' "pg_upgrade_dump_51236.custom" >>
    "pg_upgrade_dump_51236.log" 2>&1
    pg_restore: connecting to database for restore
    pg_restore: creating pg_largeobject "pg_largeobject"
    pg_restore: creating pg_largeobject_metadata "pg_largeobject_metadata"
    pg_restore: creating SCHEMA "public"
    pg_restore: creating COMMENT "SCHEMA "public""
    pg_restore: creating EXTENSION "hstore"
    pg_restore: creating COMMENT "EXTENSION "hstore""
    pg_restore: creating SHELL TYPE "public.ghstore"
    pg_restore: creating FUNCTION "public.ghstore_in("cstring")"
    pg_restore: creating FUNCTION "public.ghstore_out("ghstore")"
    pg_restore: creating TYPE "public.ghstore"
    pg_restore: creating DOMAIN "public.hstestdom1"
    pg_restore: [archiver (db)] Error while PROCESSING TOC:
    pg_restore: [archiver (db)] Error from TOC entry 579; 1247 51354
    DOMAIN hstestdom1 buildfarm
    pg_restore: [archiver (db)] could not execute query: ERROR:  pg_type
    array OID value not set when in binary upgrade mode
        Command was:
    -- For binary upgrade, must preserve pg_type oid
    SELECT
    pg_catalog.binary_upgrade_set_next_pg_type_oid('51354'::pg_catalog.oid);

    CREATE DOMAIN "hstestdom1" AS integer NOT NULL DEFAULT 0;


Here we're upgrading from 9.2 to HEAD. Of course, there isn't an array
oid for the domain in 9.2.

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers