Subject: Re: pgsql: Refactor geometric functions and operators
To: Michael Paquier <michael@paquier.xyz>,
 Tomas Vondra <tomas.vondra@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
References: <E1fjZo1-00019i-GG@gemulon.postgresql.org>
 <20180729145932.GE1471@paquier.xyz>
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Message-ID: <681b1c97-513a-0dcd-de8a-6f6a04547d1e@2ndquadrant.com>
Date: Sun, 29 Jul 2018 17:21:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20180729145932.GE1471@paquier.xyz>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 07/29/2018 04:59 PM, Michael Paquier wrote:
> On Sun, Jul 29, 2018 at 12:43:29AM +0000, Tomas Vondra wrote:
>> Refactor geometric functions and operators
>>
>> The primary goal of this patch is to eliminate duplicate code and share
>> code between different geometric data types more often, to prepare the
>> ground for additional patches.  Until now the code reuse was limited,
>> probably because the simpler types (line and point) were implemented
>> after the more complex ones.
> 
> It looks that this commit has upset a couple of OSX animals, locus and
> prairiedog:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=locust&dt=2018-07-29%2013%3A13%3A35
> 
> Some AIX animals are also upset for the same reason with the handling
> of a negative sign with 0.

Yeah, the commit broke this by inadvertedly undoing 43fe90f66a0 :-(

I've posted a fix to hackers [1]. If someone with access to an affected
machine could test if it actually does the trick, that would be nice.

[1]
https://www.postgresql.org/message-id/2fce5d35-2f07-8d72-42ec-81ed97fbe640%402ndquadrant.com

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services