From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Thomas Munro <thomas.munro@enterprisedb.com>,
        pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Remove BufFile's isTemp flag.
In-reply-to: <20171120000615.36f32ayw67xyy3h6@alap3.anarazel.de>
References: <E1eFVyl-0008J1-RO@gemulon.postgresql.org>
 <23339.1510887494@sss.pgh.pa.us>
 <20171117031149.hslkxis732hkjuog@alap3.anarazel.de>
 <24110.1510888651@sss.pgh.pa.us> <32216.1510935834@sss.pgh.pa.us>
 <20171117175811.qgrs75pgyhl42kgr@alap3.anarazel.de>
 <CAEepm=38U=A0Ftk3XV=yqHXubiCoG5mr6wxQpgxTnPVo5tJL=A@mail.gmail.com>
 <31532.1511128836@sss.pgh.pa.us>
 <20171120000615.36f32ayw67xyy3h6@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sun, 19 Nov 2017 16:06:15 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6916.1511138238.1@sss.pgh.pa.us>
Date: Sun, 19 Nov 2017 19:37:18 -0500
Message-ID: <6917.1511138238@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2017-11-19 17:00:36 -0500, Tom Lane wrote:
>> No, but if you're concerned about it, we could maintain API compatibility
>> for extensions with something like
>> #define BufFileCreateTemp(interXact) BufFileCreate(interXact)

> I don't really see a point in doing this renaming in the first
> place. It's not like the Temp suffix has become inaccurate. I'd perhaps
> not add it in the green field, but I don't see a need to change an
> existing function name. If anything it seems confusing because you'd
> miss something when trivially searching the history / comparing
> branches.

Well, that's a fair point about history, but the reason I no longer
want the Temp suffix is that it implies that there's such a thing as
a non-temp BufFile.  I think that's misleading if we've cut off any
vestige of support for it.

Anybody else have an opinion?

			regards, tom lane