Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2nV9-0002mY-T3 for pgsql-committers@arkaria.postgresql.org; Fri, 13 Oct 2017 00:06:55 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1e2nV8-00078q-T8 for pgsql-committers@arkaria.postgresql.org; Fri, 13 Oct 2017 00:06:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e2nUt-0006iD-R3 for pgsql-committers@postgresql.org; Fri, 13 Oct 2017 00:06:39 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e2nUq-00026I-F9 for pgsql-committers@postgresql.org; Fri, 13 Oct 2017 00:06:39 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v9D06Wk3006971; Thu, 12 Oct 2017 20:06:32 -0400 From: Tom Lane To: Andres Freund cc: Noah Misch , pgsql-committers@postgresql.org Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage. In-reply-to: <20171012234829.efaorzn6daebxppc@alap3.anarazel.de> References: <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> <20171012234829.efaorzn6daebxppc@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Thu, 12 Oct 2017 16:48:29 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6969.1507853192.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 12 Oct 2017 20:06:32 -0400 Message-ID: <6970.1507853192@sss.pgh.pa.us> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org Andres Freund writes: >> fe-connect.c:2382:6: warning: implicit declaration of function 'getpeere= id' [-Wimplicit-function-declaration] >> Looks like we're missing >> #include > Hm, it got removed as part of > http://git.postgresql.org/gitweb/?p=3Dpostgresql.git;a=3Dcommit;h=3D9e375= 5ecb2d058f7d123dd35a2e1784006190962 > but that's not an explanation, because Nope, because that's quite old. The oldest make log on praxis for sungazer is from 2015-08-31, and it contains these warning lines: auth.c:1585:2: warning: implicit declaration of function 'getpeereid' [-Wi= mplicit-function-declaration] ip.c:228:31: warning: large integer implicitly truncated to unsigned type = [-Woverflow] pg_locale.c:1284:3: warning: implicit declaration of function 'wcstombs_l'= [-Wimplicit-function-declaration] fe-connect.c:1991:6: warning: implicit declaration of function 'getpeereid= ' [-Wimplicit-function-declaration] ip.c:228:31: warning: large integer implicitly truncated to unsigned type = [-Woverflow] It looks like we have grown another occurrence of the "implicitly truncated" nag, but otherwise it's the same warnings in the most recent log. regards, tom lane --=20 Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers