From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: pgsql: Add hooks for session start and session end
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org
References: <E1eEzZG-0001kP-KI@gemulon.postgresql.org>
 <10176.1510764611@sss.pgh.pa.us>
 <575d6fa2-78d0-4456-8600-302fc35b2591@dunslane.net>
 <21509.1510772165@sss.pgh.pa.us>
 <762a0864-a831-1009-c2c7-297695d1e3e4@2ndQuadrant.com>
Message-ID: <6a231271-671f-a5b0-e4ba-a0ae57ba50cd@2ndQuadrant.com>
Date: Wed, 15 Nov 2017 16:11:13 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <762a0864-a831-1009-c2c7-297695d1e3e4@2ndQuadrant.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-MW
Precedence: bulk


On 11/15/2017 02:17 PM, Andrew Dunstan wrote:
>
> On 11/15/2017 01:56 PM, Tom Lane wrote:
>> Andrew Dunstan <andrew@dunslane.net> writes:
>>> On 11/15/2017 11:50 AM, Tom Lane wrote:
>>>> Andrew Dunstan <andrew@dunslane.net> writes:
>>>>> Add hooks for session start and session end
>>>> Buildfarm doesn't like this one bit :-(
>>> Strange, it worked when I tested. I'll look into it.
>> Looks to me like the problem is that the test can only work in "check"
>> mode, not "installcheck" mode, because in the latter case you don't
>> get to do preloaded libraries.
>>
>> 			
>
>
> Yeah, that was my first instinct. But then how do the test_rls_hooks
> tests succeed? They too have a shared_preload_library.
>


Aha, it does

    LOAD 'test_rls_hooks';

at the start of its script. Of course we can't do that here.

Not sure what the best way to resolve this is. For now I'm inclined just
to override the installcheck target in the module's makefile and disable
it in vcregress.pl.

Maybe we need to shift from installcheck to check mode for these
modules. That would involve a buildfarm script change.


cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services