Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rvKDD-00BFn3-Ql for pgsql-committers@arkaria.postgresql.org; Fri, 12 Apr 2024 16:57:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rvKDC-00GF6x-Qu for pgsql-committers@arkaria.postgresql.org; Fri, 12 Apr 2024 16:57:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rvKDC-00GF6b-F8 for pgsql-committers@lists.postgresql.org; Fri, 12 Apr 2024 16:57:14 +0000 Received: from lahtoruutu.iki.fi ([2a0b:5c81:1c1::37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rvKD8-002XNU-Uz for pgsql-committers@lists.postgresql.org; Fri, 12 Apr 2024 16:57:13 +0000 Received: from [172.19.157.206] (unknown [212.174.35.38]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 4VGN5Y4TjTz49Pyl; Fri, 12 Apr 2024 19:57:05 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1712941026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g5leOSzFkvlsVh1AoX1yB/4OrW2NniKtOSMtqo05F3M=; b=YbF4TIoSevzOlDyygRynpVim3g7keDj3iy2ChaQgwAhdTzAB2w1RK+GbKUYXJQDpOMlPn9 An04qg9WSqCbKsS2FxxV+yvN6SeVvMsSs7cgVvT5xo5NAAfOmoiiXF9qNivOaiVr+fZwvu QogcgcHFDUBHXBC7wWC3nMWGBsT+Dte5+q6MkHQzIqJYUi9bB4l2nNFMy8esGVwrqk+f/e Dfxi4m1icufllrKv4s/osAAtYiszBqbrq7yOE1NJXqEfrpWRzk++p+HzeN8yxcI7WRQGs8 9FffolYTmdtoKYceJtY2MlUfc3K1fXErIcZgMUUC4uEzp5D8RBsCsPzp9gST7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1712941026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g5leOSzFkvlsVh1AoX1yB/4OrW2NniKtOSMtqo05F3M=; b=SR/gjlaRI7AlL+Tn1TZnomORuS3fmAqk1ZSG0Yp1FbfSj5IGDPw6Gu0R/rK2XYWb25EeLL jfMLqoXInJXqwOI0jfGCnw+cDL21akmjunWRDufuIReDKXOuEdrm7Fw4MhAKGXylscw5Ty N0qyqdsXH8nNwUMy4aVRf6GKuxUlGP5oK9kcHlMTSbwOHOhl5JLTNxs14Xh6MbfzfdTduH rgoLKfkqDZDr80TWMFwkJ3Fm/GgaV0jEcDaH1EPaSYXReaIwlM5M9axlCLv/rwNxIXNhOq 6QzDqU0f3sjrdBmgmoUzNhRmWgbrf7zKU3L0TafIoml/1G2svYX8mQC1XAOaKA== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1712941026; a=rsa-sha256; cv=none; b=iC/2BdirhqHh3do6Ayu3Zp/Ske8QHAW/OWwyjPqFS6YZKaZ6aEJb1bJAwd6ucb6WQQRvRe 9rHNVsATaUVfIH4pyrtpkWBye66TAZCpI9Xp4tBkXBED4cLdNjmWaE9JMMbY66PkcAp5sK Sf8DZ5Ely6JnBLIApTaA2yqqbLOVuzZK8jyE2MNvFHPRi77lsn3gRb32UwqfOtQIzVXeQ3 JovzrOQ92Cv+lZyynbNiRNu+q/tPd/w8kLWOr/1DumVYxfx3ffxc5PWVVK/fz77MHWMgG2 AJs6MmwzH5j7ijwCl2c9CD6tWyTUDGtZMGRUqaEIOgb65GVCCoRhn4nSLQynIA== Message-ID: <6a720823-d946-4f8e-a111-ee0998082b73@iki.fi> Date: Fri, 12 Apr 2024 19:57:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Refactor libpq state machine for negotiating encryption From: Heikki Linnakangas To: Thomas Munro Cc: Heikki Linnakangas , pgsql-committers@lists.postgresql.org, Tom Lane References: <32196.1712791542@sss.pgh.pa.us> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 11/04/2024 20:07, Heikki Linnakangas wrote: > On 11/04/2024 02:33, Thomas Munro wrote: >> On Thu, Apr 11, 2024 at 11:25 AM Tom Lane wrote: >>> Thomas Munro writes: >>>> If -Dssl=none and -Dgssapi=disabled, compilation of fe-connect.c >>>> fails: call to undeclared function 'encryption_negotiation_failed'. I >>>> didn't look too hard, but maybe ENABLE_GSS and USE_GSS are confused? >>> >>> For me, configure --with-gssapi fails like that, but the other three >>> combinations of --with-openssl and --with-gssapi compile OK. I don't >>> find it terribly surprising that the buildfarm isn't covering that >>> combination ... >> >> Oops, right, correction to my report: it is indeed -Dssl=none >> -Dgssapi=enabled that is broken, not the other combinations. > > Yes, I misspelled ENABLE_GSS as USE_GSS. > > After fixing that, the new tests are failing; the expected output for > many of the cases is different when GSSAPI support is not compiled in. I > think the test tables need to be rearranged some more to take that into > account, or we will end up with a ridiculous amount of different > expected outputs. > > I will take a closer look at that tomorrow. As a bandaid fix, we could > temporarily disable the new tests with that combination of configure > options, it's still better test coverage than not having the tests at > all. But given that no buildfarm members are testing that combination I > think it can wait a day. Fixed the compilation with that combination, and the expected test output. Thanks for the report! -- Heikki Linnakangas Neon (https://neon.tech)