Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plAlu-0003MX-2c for pgsql-committers@arkaria.postgresql.org; Sat, 08 Apr 2023 15:46:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1plAls-0006Z2-Mg for pgsql-committers@arkaria.postgresql.org; Sat, 08 Apr 2023 15:46:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plAls-0006Ys-FX for pgsql-committers@lists.postgresql.org; Sat, 08 Apr 2023 15:46:32 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1plAln-001f5t-QH for pgsql-committers@lists.postgresql.org; Sat, 08 Apr 2023 15:46:31 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 7A161240002; Sat, 8 Apr 2023 15:46:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------7dlKJtdqITGa4014lf0JOAFV" Message-ID: <6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net> Date: Sat, 8 Apr 2023 11:46:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: pgsql: Skip \password TAP test on old IPC::Run versions Content-Language: en-US To: Daniel Gustafsson , pgsql-committers@lists.postgresql.org References: From: Andrew Dunstan In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------7dlKJtdqITGa4014lf0JOAFV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2023-04-08 Sa 09:57, Daniel Gustafsson wrote: > Skip \password TAP test on old IPC::Run versions > > IPC::Run versions prior to 0.98 cause the interactive session to time out, > so SKIP the test in case these versions are detected (they are within the > base requirement for our TAP tests in general). Error reported by the BF > and investigation by Tom Lane. > > Discussion:https://postgr.es/m/414A86BD-986B-48A7-A1E4-EEBCE5AF08CB@yesql.se Stylistic nitpick: It's not necessary to have 2 evals here: +   skip "IO::Pty and IPC::Run >= 0.98 required", 1 unless +       (eval { require IO::Pty; } && eval { $IPC::Run::VERSION >= '0.98' }); just say "eval { require IO::Pty; return $IPC::Run::VERSION >= '0.98'; }" cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------7dlKJtdqITGa4014lf0JOAFV Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 2023-04-08 Sa 09:57, Daniel Gustafsson wrote:
Skip \password TAP test on old IPC::Run versions

IPC::Run versions prior to 0.98 cause the interactive session to time out,
so SKIP the test in case these versions are detected (they are within the
base requirement for our TAP tests in general).  Error reported by the BF
and investigation by Tom Lane.

Discussion: https://postgr.es/m/414A86BD-986B-48A7-A1E4-EEBCE5AF08CB@yesql.se


Stylistic nitpick: It's not necessary to have 2 evals here:


+   skip "IO::Pty and IPC::Run >= 0.98 required", 1 unless
+       (eval { require IO::Pty; } && eval { $IPC::Run::VERSION >= '0.98' });


just say "eval { require IO::Pty; return $IPC::Run::VERSION >= '0.98'; }"


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com
--------------7dlKJtdqITGa4014lf0JOAFV--