Message-ID: <6e625c81-968e-42d0-802d-edfaf9cfac11@xs4all.nl>
Date: Thu, 23 Jan 2025 12:26:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Doc: Update the interaction of tablesync with
 wal_retrieve_retry
To: Amit Kapila <akapila@postgresql.org>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <E1taTNm-002rJC-PX@gemulon.postgresql.org>
Content-Language: en-US
From: Erik Rijkers <er@xs4all.nl>
In-Reply-To: <E1taTNm-002rJC-PX@gemulon.postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/6e625c81-968e-42d0-802d-edfaf9cfac11%40xs4all.nl>
Precedence: bulk

On 1/22/25 06:34, Amit Kapila wrote:
> Doc: Update the interaction of tablesync with wal_retrieve_retry_interval.
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/4a0e7314f11ee03adfe9df945598c068b4179314

Hi,

In this sentence :

"The initial data in existing subscribed tables are snapshotted and
copied in a parallel instances of a special kind of apply process."

"copied in a parallel instances" seems wrong. It should be either
(1) singular "in a parallel instance" or
(2) plural "in parallel instances"

I'm not sure which is meant.  I also wonder if 'instance' is actually 
the correct word here at all; see the Glossary definition of 'instance':

"A group of backend and auxiliary processes that communicate
using a common shared memory area. One postmaster process
manages the instance; one instance manages exactly one database
cluster with all its databases. Many instances can run on the same
server as long as their TCP ports do not conflict."

Thanks,

Erik


> Modified Files
> --------------
> doc/src/sgml/config.sgml              |  3 ++-
> doc/src/sgml/logical-replication.sgml | 35 +++++++++++++++++++++++------------
> 2 files changed, 25 insertions(+), 13 deletions(-)
>