From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: aio: Add core asynchronous I/O infrastructure
In-reply-to: <a54pqocps46awa4b2tlwmrjz5k3b3jastg5py6thtnqtlr2ksy@notafhjwiuec>
References: <E1tuJo6-0030Bd-0C@gemulon.postgresql.org>
 <93029.1742310216@sss.pgh.pa.us>
 <ecqk4e772iqtwuwfu56yr3cv5wnzug6fpqvmwjcwlduqlom5xr@2fzz3cdycdyb>
 <95354.1742311575@sss.pgh.pa.us>
 <a54pqocps46awa4b2tlwmrjz5k3b3jastg5py6thtnqtlr2ksy@notafhjwiuec>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 19 Mar 2025 10:29:19 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <713809.1742402548.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 19 Mar 2025 12:42:28 -0400
Message-ID: <713810.1742402548@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/713810.1742402548%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2025-03-18 11:26:15 -0400, Tom Lane wrote:
>> Well, if we don't want to fix it I can just adjust my warning-scraping
>> script to ignore these.  Let's wait a bit and see if any newer
>> compilers warn similarly before deciding.

> FWIW, adding a few casts does silence the warnings, at least on clang-3.=
9,
> which I had around.

As of now, the only BF members showing these warnings are ayu (clang
version 4.0.1-10~deb9u2), batfish (clang version 5.0.0-3~16.04.1),
and demoiselle (clang version 5.0.1).  None of those seem like
versions that anyone would use for code development anymore (clang 6.0
was released in March 2018), so I'm not feeling like these warnings
are important to silence.  Let's just ignore them.

> But there also are other warnings on that compiler, mainly stuff like:
> ../../home/andres/src/postgresql/src/interfaces/libpq/fe-auth-oauth-curl=
.c:1437:28: warning: suggest braces around initialization of subobject [-W=
missing-braces]
>         struct itimerspec spec =3D {0};

And even more so that, if it's so old it's not even in the buildfarm
anymore.  I do care about -Wmissing-braces on a version developers
might use, but ...

			regards, tom lane