Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfkbS-00011g-Tz for pgsql-committers@arkaria.postgresql.org; Wed, 27 Oct 2021 15:12:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mfkbR-0003JJ-Os for pgsql-committers@arkaria.postgresql.org; Wed, 27 Oct 2021 15:12:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfkbR-0003JA-Cs for pgsql-committers@lists.postgresql.org; Wed, 27 Oct 2021 15:12:33 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mfkbM-00042S-CX for pgsql-committers@lists.postgresql.org; Wed, 27 Oct 2021 15:12:32 +0000 Received: by mail-pf1-x431.google.com with SMTP id x66so2975576pfx.13 for ; Wed, 27 Oct 2021 08:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=iQ9GCYzCGJPAS9pHT+UnxhFl9T91YvEyU9Ek1LJqAh4=; b=wUUiEir3UsdPWjBh2TMZOEiYKDGAzcBD4polCtiOP+IMe38Y7ylRTlWfxiqwsXxqtm kOTYdFRaRw6ZUoOoAFxpXKToWdIsCUdMAoaFxSk4gqpOwaTXSGF76WDYTEb13ukGza6x qTwGDBuYPiHWNfTX0WhVZvqId8H6DvEVHM+j9jlS7txIPXX/b3vVQYP+KSCVNzdhjFQp 3DVbWHGp0TJM/FNxdpadVSUlLKv64aFe+JJ9UB8qbBMxXcoUbdWCBvZawHOk4vXMPWNy quta3nBSv78UYBUTiQwXHNd6zrZXqVf3Dtua7koc3opfWpdXLDTRxzqKVqoWJ7JkyY1E Accg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=iQ9GCYzCGJPAS9pHT+UnxhFl9T91YvEyU9Ek1LJqAh4=; b=C9LDYOuRkqYfujnJ/5YgqHwVXpL8YCFDB0+nCjdVWEPQrAL/kwukHifhCO1krdUwZs qDVYR06YvhfbjOlS5cYddGqz9gzPJ677UtHfbJJCHMZEdZTFd1zzH8QE4txyQxb3Thdj BQjnjFLnzhsdH6etEQJdiVj/mqlAN9JxP6Zta8++yHIWbhZw02oOFNJZz1tg7AKhx6Z9 LZmbnroDmYPzZzX+xsdN/m6+9Gm7bGBnqEbyBtyJoNpqhk6oF3f/QyBBr7H7LllBWRec kBe60dJ20mXOgV3y2/8638VPmVHYtRq16QB367dgdW0IZpebaj5Ys4+RBYKSw1fL7UR/ mg1Q== X-Gm-Message-State: AOAM533/4GQAzzt//9TPyH4pMG8CvBT0XD7IsWJuRTCejhZD4dDx/bfU Pw5l3lb+vGrtI5UXKm/Ed41Sjw== X-Google-Smtp-Source: ABdhPJytpbiLpxIHBcAErEZfDBlYrpW6GZeE/jLXxSxci7p8nHFAL/wd0zyZsCt4eRvm2UH7pduxAQ== X-Received: by 2002:a63:101c:: with SMTP id f28mr23870200pgl.330.1635347546059; Wed, 27 Oct 2021 08:12:26 -0700 (PDT) Received: from jdavis.lan (c-73-231-146-4.hsd1.ca.comcast.net. [73.231.146.4]) by smtp.gmail.com with ESMTPSA id o25sm142273pgn.47.2021.10.27.08.12.25 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Oct 2021 08:12:25 -0700 (PDT) Message-ID: <71a623546abe5b3ba4b4f1370c78db96aac37c5a.camel@j-davis.com> Subject: Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts(). From: Jeff Davis To: Michael Paquier , Jeff Davis Cc: pgsql-committers@lists.postgresql.org Date: Wed, 27 Oct 2021 08:12:23 -0700 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, 2021-10-27 at 13:15 +0900, Michael Paquier wrote: > I don't think that the documentation part of this commit is correct. > This sentence should have been changed to something like the > following: > "This function is restricted to superusers by default, but other > users > can be granted EXECUTE to run the function." Above the table of functions it already says: "Use of these functions is restricted to superusers by default but access may be granted to others using GRANT, with noted exceptions." It looks like several people missed that, so perhaps we should get rid of that statement at the top, and move it in to each function description? Regards, Jeff Davis