Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tzkzI-006DdR-NH for pgsql-committers@arkaria.postgresql.org; Tue, 01 Apr 2025 23:25:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tzkzH-0080iX-EJ for pgsql-committers@arkaria.postgresql.org; Tue, 01 Apr 2025 23:25:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tzkzH-0080iA-6o for pgsql-committers@lists.postgresql.org; Tue, 01 Apr 2025 23:25:43 +0000 Received: from fout-a6-smtp.messagingengine.com ([103.168.172.149]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tzkzD-002qfg-1G for pgsql-committers@lists.postgresql.org; Tue, 01 Apr 2025 23:25:42 +0000 Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id 20C1C1383842; Tue, 1 Apr 2025 19:25:37 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Tue, 01 Apr 2025 19:25:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1743549937; x=1743636337; bh=YVZMcMZOkZk74vlR96WZR6JgGP2uqhjyW7h5Netfksk=; b= Wn+yU+PmVlTInKVrxrhZBrFg3OlItJqW6j8qfF+H4YhwyP6KBQf/68Scvo3mk/XW gUpDwd+WwVhbWkLKDiiAHm5znDpYJwoVfzEFv4x4P+NntlI5qFFDYy+OOeIo+Bj7 G8BNTf4c1GKp8tQZjHcKmW1SQtvUvjC5pUpKTf/Q4mopaliimUwwpgnDqadRSFU6 HNn9lMpHwC5/Ko57CcqP4xiBt1LxcSwZIj/LH+TJ2QQc2lUIlWLQZKPz6aPoz+Oh fW+mK35YeJPefWClRvfyBCKKDTXmfcNHcq+ukH1dB7QFfVTZfNwmzFUb6nGpUsZ4 qx7hwn0jQYzXOgWDIDzlQA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1743549937; x= 1743636337; bh=YVZMcMZOkZk74vlR96WZR6JgGP2uqhjyW7h5Netfksk=; b=E VYcbMIxqTMCUNu/xC75Ls6KJ74HZqcuq3yvTqnjPyevoYuFi3I+tLpRqPhfZyskj 7YP29MrqAzS2i7tYwiWW/ICNnIyv3P9JyNFgjCmTUat5r72Lh5IdG6pkMWIiV8JK pw4xkKhKBecqlc6c6xTKmS85HD7ULvyDosH2pn334lOcyXj6o9WpO/RU8lXaj724 MlHvWF4XRjjW31xkNmbPSmOmxwaDqw4A6ti1kl7V0uly8UrtGST2uUoFAVcq3v5Q yeixw1RlMqnB177fkqIX6uzjQUG2K+Z/49dXeXMmiF0qTgFZz4lBM7W4A+caMxWn MF3UQ+2sRJUX3oHsJJA6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddukeegudduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffuc dljedtmdenucfjughrpegtgffhggfufffkfhevjgfvofesthhqmhdthhdtjeenucfhrhho mhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrd ighiiiqeenucggtffrrghtthgvrhhnpedvgeeufedvjeffhfejgfettefhleehkefhheeu vdegfeeiiedujefftdfhveejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipdhnsggprhgt phhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehpghhsqhhlsehjqd gurghvihhsrdgtohhmpdhrtghpthhtohepphhgshhqlhdqtghomhhmihhtthgvrhhssehl ihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Apr 2025 19:25:36 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Michael Paquier Mime-Version: 1.0 (1.0) Subject: Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing Date: Wed, 2 Apr 2025 08:25:24 +0900 Message-Id: <72173298-8CF2-489E-9549-27A224D30A3F@paquier.xyz> References: <8e540416ec3f0a5850264505bf4c72844d32176a.camel@j-davis.com> Cc: pgsql-committers@lists.postgresql.org In-Reply-To: <8e540416ec3f0a5850264505bf4c72844d32176a.camel@j-davis.com> To: Jeff Davis X-Mailer: iPhone Mail (22D82) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mar 31, 2025, at 3:12, Jeff Davis wrote: > Why pg_strdup() the "NULL" at all in that case? Usually I see that done > so that there doesn't need to be a conditional when freeing, but here > there's a conditional anyway. >=20 > Perhaps something like the attached? This would work for me as well. I=E2=80=99m ok to take care of it at the beg= inning of next week, based on your suggestion. -- Michael