From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework option set of vacuumlo
In-reply-to: <20180828213701.GL29157@paquier.xyz>
References: <E1fudM8-0000af-Lm@gemulon.postgresql.org>
 <12438.1535488750@sss.pgh.pa.us> <17758.1535490505@sss.pgh.pa.us>
 <20180828213701.GL29157@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 28 Aug 2018 14:37:01 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7227.1535492867.1@sss.pgh.pa.us>
Date: Tue, 28 Aug 2018 17:47:47 -0400
Message-ID: <7228.1535492867@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Aug 28, 2018 at 05:08:25PM -0400, Tom Lane wrote:
>> Oh!  The reason why not is that that line is inside "ifdef REGRESS",
>> and these subdirectories have no REGRESS tests.  So we should move
>> that out to where it will apply regardless of that.  Will fix.

> Yes, I was going to send a patch along the same lines as what you have
> just committed.  Thanks!  It looks that the binary was installed in my
> own PATH, so I did not notice it.

> This should definitely get back-patched in my opinion, I have similar
> problems with pg_rewind tests of 9.3 and 9.4 that I still maintain out
> of the core tree, where the main binary needs to be installed first.  In
> this case I just used some Makefile trick.

I didn't want to backpatch further than v11 without a test case that would
work in those branches, and I lacked one.  If you've got out-of-core code
you could verify it with, please do that and back-patch further.

			regards, tom lane