pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: doc: Fix incorrect wording for --file in pg_dump
5+ messages / 4 participants
[nested] [flat]
Commits from this thread:
2025-11-27 e396a18f32 doc: Fix typo in pg_dump documentation
* pgsql: doc: Fix incorrect wording for --file in pg_dump
@ 2025-11-07 14:27 Daniel Gustafsson <dgustafsson@postgresql.org>
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Gustafsson @ 2025-11-07 14:27 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
doc: Fix incorrect wording for --file in pg_dump
The documentation stated that the directory specified by --file
must not exist, but pg_dump does allow for empty directories to
be specified and used.
Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Bruce Momjian <bruce@momjian.us>
Discussion: https://postgr.es/m/534AA60D-CF6B-432F-9882-E9737B33D1B7@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/07961ef86625be91e243f1dff8911cb1d70e443f
Modified Files
--------------
doc/src/sgml/ref/pg_dump.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: doc: Fix incorrect wording for --file in pg_dump
@ 2025-11-27 05:48 Erik Rijkers <er@xs4all.nl>
parent: Daniel Gustafsson <dgustafsson@postgresql.org>
0 siblings, 2 replies; 5+ messages in thread
From: Erik Rijkers @ 2025-11-27 05:48 UTC (permalink / raw)
To: Daniel Gustafsson <dgustafsson@postgresql.org>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Op 11/7/25 om 15:27 schreef Daniel Gustafsson:
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/07961ef86625be91e243f1dff8911cb1d70e443f
>
> Modified Files
> --------------
> doc/src/sgml/ref/pg_dump.sgml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Hi,
In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:
"unless the directory exist and is empty." should be
"unless the directory exists and is empty."
i.e., 'exists': because 'directory' is singular.
Thanks!
Erik
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: doc: Fix incorrect wording for --file in pg_dump
@ 2025-11-27 06:32 Chao Li <li.evan.chao@gmail.com>
parent: Erik Rijkers <er@xs4all.nl>
1 sibling, 0 replies; 5+ messages in thread
From: Chao Li @ 2025-11-27 06:32 UTC (permalink / raw)
To: Erik Rijkers <er@xs4all.nl>; +Cc: Daniel Gustafsson <dgustafsson@postgresql.org>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
> On Nov 27, 2025, at 13:48, Erik Rijkers <er@xs4all.nl> wrote:
>
> Op 11/7/25 om 15:27 schreef Daniel Gustafsson:
>> Branch
>> ------
>> master
>> Details
>> -------
>> https://git.postgresql.org/pg/commitdiff/07961ef86625be91e243f1dff8911cb1d70e443f
>> Modified Files
>> --------------
>> doc/src/sgml/ref/pg_dump.sgml | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Hi,
>
> In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:
>
> "unless the directory exist and is empty." should be
> "unless the directory exists and is empty."
>
> i.e., 'exists': because 'directory' is singular.
>
+1, agreed.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: doc: Fix incorrect wording for --file in pg_dump
@ 2025-11-27 06:33 Michael Paquier <michael@paquier.xyz>
parent: Erik Rijkers <er@xs4all.nl>
1 sibling, 1 reply; 5+ messages in thread
From: Michael Paquier @ 2025-11-27 06:33 UTC (permalink / raw)
To: Erik Rijkers <er@xs4all.nl>; +Cc: Daniel Gustafsson <dgustafsson@postgresql.org>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Nov 27, 2025 at 06:48:56AM +0100, Erik Rijkers wrote:
> In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:
>
> "unless the directory exist and is empty." should be
> "unless the directory exists and is empty."
>
> i.e., 'exists': because 'directory' is singular.
Indeed, good catch. Daniel will very likely show up. If not, I'll go
apply a fix.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: doc: Fix incorrect wording for --file in pg_dump
@ 2025-11-27 09:32 Daniel Gustafsson <dgustafsson@postgresql.org>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Gustafsson @ 2025-11-27 09:32 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: Erik Rijkers <er@xs4all.nl>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
> On 27 Nov 2025, at 07:33, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Nov 27, 2025 at 06:48:56AM +0100, Erik Rijkers wrote:
>> In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:
>>
>> "unless the directory exist and is empty." should be
>> "unless the directory exists and is empty."
>>
>> i.e., 'exists': because 'directory' is singular.
>
> Indeed, good catch. Daniel will very likely show up. If not, I'll go
> apply a fix.
Done, sorry for the delay.
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2025-11-27 09:32 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-11-07 14:27 pgsql: doc: Fix incorrect wording for --file in pg_dump Daniel Gustafsson <dgustafsson@postgresql.org>
2025-11-27 05:48 ` Erik Rijkers <er@xs4all.nl>
2025-11-27 06:32 ` Chao Li <li.evan.chao@gmail.com>
2025-11-27 06:33 ` Michael Paquier <michael@paquier.xyz>
2025-11-27 09:32 ` Daniel Gustafsson <dgustafsson@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox