Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZgN9-00065Z-EP for pgsql-committers@arkaria.postgresql.org; Wed, 30 Mar 2022 22:00:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZgN7-0003Yo-AX for pgsql-committers@arkaria.postgresql.org; Wed, 30 Mar 2022 22:00:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZgN7-0003Ye-3V for pgsql-committers@lists.postgresql.org; Wed, 30 Mar 2022 22:00:57 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZgN4-0005iB-Gh for pgsql-committers@lists.postgresql.org; Wed, 30 Mar 2022 22:00:56 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 7573C2F1FFEA for ; Thu, 31 Mar 2022 00:00:53 +0200 (CEST) Received: from s645.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 663BB2E318EF; Thu, 31 Mar 2022 00:00:53 +0200 (CEST) Received: from s476.loopia.se (unknown [172.22.191.5]) by s645.loopia.se (Postfix) with ESMTP id 5A35A157B0A8; Thu, 31 Mar 2022 00:00:53 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s499.loopia.se ([172.22.191.5]) by s476.loopia.se (s476.loopia.se [172.22.190.16]) (amavisd-new, port 10024) with LMTP id kCOgJcGbcBZ2; Thu, 31 Mar 2022 00:00:53 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from [192.168.72.144] (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s499.loopia.se (Postfix) with ESMTPSA id EEE001CE5FB6; Thu, 31 Mar 2022 00:00:52 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: pgsql: Add function to pump IPC process until string match From: Daniel Gustafsson In-Reply-To: <20220330160916.vpsxtjss25yfyq3p@alap3.anarazel.de> Date: Thu, 31 Mar 2022 00:00:52 +0200 Cc: pgsql-committers@lists.postgresql.org, Michael Paquier Content-Transfer-Encoding: quoted-printable Message-Id: <72D87565-A0A6-42DC-BF0D-3C1E4AFB8237@yesql.se> References: <20220329225819.ahk5u2tax3ez6d2t@alap3.anarazel.de> <20220330160916.vpsxtjss25yfyq3p@alap3.anarazel.de> To: Andres Freund X-Mailer: Apple Mail (2.3608.120.23.2.7) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 30 Mar 2022, at 18:09, Andres Freund wrote: >> Would adding back something like the (right now untested) below be = what you're >> after? Looking at the perldoc I didn't see any other debugging aids = we can >> emit other than the stream and type of error. >=20 > I found showing the regex from before useful. Often there's many > pump_until()'s, and the regex makes it easier to figure out what = errored > out. And it shows quoting problem. Since it only happens when there = was a > failure, it's not like it'll bloat the log unduly. I'll add diag output on failures along the lines of the diff from = earlier today but with the regex as well (which Alvarao also requested), but tomorrow = morning once coffee has been consumed. -- Daniel Gustafsson https://vmware.com/