Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSTnE-0007iw-16 for pgsql-committers@arkaria.postgresql.org; Fri, 11 Mar 2022 01:10:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nSTnC-0000mG-1i for pgsql-committers@arkaria.postgresql.org; Fri, 11 Mar 2022 01:10:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSTnB-0000m7-RL for pgsql-committers@lists.postgresql.org; Fri, 11 Mar 2022 01:10:05 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSTn7-0007rx-4e for pgsql-committers@lists.postgresql.org; Fri, 11 Mar 2022 01:10:05 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22B19uZL758108; Thu, 10 Mar 2022 20:09:56 -0500 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: dshash: Add sequential scan support. In-reply-to: References: Comments: In-reply-to Andres Freund message dated "Fri, 11 Mar 2022 01:02:51 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <758106.1646960996.1@sss.pgh.pa.us> Date: Thu, 10 Mar 2022 20:09:56 -0500 Message-ID: <758107.1646960996@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > dshash: Add sequential scan support. > Add ability to scan all entries sequentially to dshash. The interface is > similar but a bit different both from that of dynahash and simple dshash > search functions. The most significant differences is that dshash's interfac > always needs a call to dshash_seq_term when scan ends. Umm ... what about error recovery? Or have you just cemented the proposition that long-lived dshashes are unsafe? regards, tom lane