Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eF3Bn-0003Rx-JJ for pgsql-committers@arkaria.postgresql.org; Wed, 15 Nov 2017 19:17:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eF3Bn-0000gs-18 for pgsql-committers@arkaria.postgresql.org; Wed, 15 Nov 2017 19:17:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eF3Bm-0000gb-PK for pgsql-committers@lists.postgresql.org; Wed, 15 Nov 2017 19:17:34 +0000 Received: from mail-yw0-x232.google.com ([2607:f8b0:4002:c05::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eF3Bi-0004rq-Ry for pgsql-committers@postgresql.org; Wed, 15 Nov 2017 19:17:34 +0000 Received: by mail-yw0-x232.google.com with SMTP id v75so478432ywa.7 for ; Wed, 15 Nov 2017 11:17:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=iONY6bGX1pe/55E0BOAY3fbNung6qYhLVyrom6/9TvQ=; b=fkQD0PkyKOFT+EZviWAV/Nnh/CGRctDJywv0DWozgz188gnkMCjRk8FOfGH12AgEfl Xc6IpJZrm05I/kqYLOAl3511kw4yJ9szoEpXD9SUinXfdu6MujOoJvrbJROfGo0cKD09 yEQZreX3IDKUirR1ZveD45CSA2AZhLrqdyYrkvhjPrKuIaM/c0c33MPLpHIY0fvNa5oe CjXir6pEO7DhK/zgtqVKKAxNj40ypVSSMfqKpezQaXcDWHDBdq6zKFkgGN60YELKHNzD Pi5ZRD6rDqudL5r3UUe3wzm9bnNH48bfUJTFC4v7WrSOzUXeiJ1Jnff18aQj/MzcCfl2 FnMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=iONY6bGX1pe/55E0BOAY3fbNung6qYhLVyrom6/9TvQ=; b=SDzHQniBa8j3l5XS2IMly0wHBZe7il4d9gE4/H8wLCVNcLKlCGmXlmPPnow3GSz6uQ Q4p0rkXR1M6/IqbgNns3B147l2mJdPyCN08Fd8aNrRwvgutFAok6Wc+eoOFAi9ic1lO8 tK+IsxoVLTn9HkC0acGooOKIer5eUNb0gRqTVXWcuG1jdWVX9rWPY0q6SAA2rGH/fUE2 M9JsZoRa0z22RkLPDSJG5rs3qbrSQdIIgqoHiB/osXsaKAqpe//fjVYBGsSqX4nKTxaD t6XW5XOK3E8MYso7qqBTArmGkSEuOk7/31m5W5KJAR4MxDj6OeEulhStKPcej8RpJMue 5GvA== X-Gm-Message-State: AJaThX5QYNeW1QHnhqegef82gAQaorqcv6MMaFFysz+wPR/Q0sYSJ+la WyKKcxsY5lEEHz2oPXFKUOSuwqVWRTmEARUrSFyKmxwegRP45jXW7I9csqfLzRLlnvPQcfHcgaX vD4iPe1XvCznsofwZ5qRP/cy4JYAFg2m3NxBj0Mv1xEqHJ7aZJYZ2dpJP0RkqR6Bdbf4rlbL3xB 5g+fM8ysHG4i6/aVm5 X-Google-Smtp-Source: AGs4zMaztc98KKtPYhODTUYl18XSqRjRGViy6xgUMns8YNr286eRMy/go7//fILdArsWrXACpRx+Zw== X-Received: by 10.129.85.149 with SMTP id j143mr10981025ywb.458.1510773448201; Wed, 15 Nov 2017 11:17:28 -0800 (PST) Received: from [192.168.10.146] ([98.122.175.38]) by smtp.gmail.com with ESMTPSA id 129sm2638293ywr.90.2017.11.15.11.17.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Nov 2017 11:17:27 -0800 (PST) From: Andrew Dunstan X-Google-Original-From: Andrew Dunstan Subject: Re: pgsql: Add hooks for session start and session end To: Tom Lane Cc: pgsql-committers@postgresql.org References: <10176.1510764611@sss.pgh.pa.us> <575d6fa2-78d0-4456-8600-302fc35b2591@dunslane.net> <21509.1510772165@sss.pgh.pa.us> Message-ID: <762a0864-a831-1009-c2c7-297695d1e3e4@2ndQuadrant.com> Date: Wed, 15 Nov 2017 14:17:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <21509.1510772165@sss.pgh.pa.us> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-MW List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 11/15/2017 01:56 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 11/15/2017 11:50 AM, Tom Lane wrote: >>> Andrew Dunstan writes: >>>> Add hooks for session start and session end >>> Buildfarm doesn't like this one bit :-( >> Strange, it worked when I tested. I'll look into it. > Looks to me like the problem is that the test can only work in "check" > mode, not "installcheck" mode, because in the latter case you don't > get to do preloaded libraries. > > Yeah, that was my first instinct. But then how do the test_rls_hooks tests succeed? They too have a shared_preload_library. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services