Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ipa4n-0000Ar-NQ
	for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jan 2020 15:50:25 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ipa4m-0003Q9-7D
	for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jan 2020 15:50:24 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ipa4l-0003Q2-Rc
	for pgsql-hackers@lists.postgresql.org; Thu, 09 Jan 2020 15:50:23 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ipa4f-0007lh-HD
	for pgsql-hackers@postgresql.org; Thu, 09 Jan 2020 15:50:22 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 009FoBku007657;
	Thu, 9 Jan 2020 10:50:11 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christoph Berg <myon@debian.org>
cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
        Amit Kapila <amit.kapila16@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
In-reply-to: <20200109145900.GF4192@msg.df7cb.de>
References: <E1in6ft-0004zR-6l@gemulon.postgresql.org>
 <20200103110128.GA28967@msg.df7cb.de> <13708.1578059577@sss.pgh.pa.us>
 <25771.1578249042@sss.pgh.pa.us> <20200106105608.GB18560@msg.df7cb.de>
 <3764.1578323719@sss.pgh.pa.us> <20200106191303.GA3975@msg.df7cb.de>
 <19973.1578351988@sss.pgh.pa.us> <28773.1578436137@sss.pgh.pa.us>
 <CA+TgmoZC_6z3d5+6n1GVfy898uoBHMPPJU4-nAQLG5ZkaEyqdQ@mail.gmail.com>
 <20200109145900.GF4192@msg.df7cb.de>
Comments: In-reply-to Christoph Berg <myon@debian.org>
	message dated "Thu, 09 Jan 2020 15:59:00 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7655.1578585011.1@sss.pgh.pa.us>
Date: Thu, 09 Jan 2020 10:50:11 -0500
Message-ID: <7656.1578585011@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Christoph Berg <myon@debian.org> writes:
> Fwiw if libedit in xenial is Just Broken and fixing the tests would
> just codify the brokenness without adding any value, I'll just disable
> that test in that particular build. It looks like setting
> with_readline=no on the make command line should work.

That would disable psql's tab completion, command editing, and history
altogether, which I doubt is what you want for production builds.
If we conclude we can't work around the testing issues for ancient
libedit, probably the right answer is to provide a switch to
disable just the test.  I've been trying to dance around that
conclusion, but maybe we should just do it and move on.

			regards, tom lane