Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnkvf-0002zl-RE for pgsql-committers@arkaria.postgresql.org; Sat, 15 Apr 2023 18:47:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pnkve-0005sx-6D for pgsql-committers@arkaria.postgresql.org; Sat, 15 Apr 2023 18:47:18 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pnkvd-0005sh-1E for pgsql-committers@lists.postgresql.org; Sat, 15 Apr 2023 18:47:17 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by makus.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1pnkva-00009h-TH for pgsql-committers@lists.postgresql.org; Sat, 15 Apr 2023 18:47:15 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 809C0581E8F; Sat, 15 Apr 2023 14:47:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 15 Apr 2023 14:47:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1681584430; x= 1681591630; bh=OXEmkPRR0D/vDpayxErXQRD20iBwRoBxxfKN3w6Caek=; b=I ElMoGCJ3Ev3pZwHRlJdI6AXEgnDNpHprdR8FtAxHxCVZE2wN2g5P157AmT5b8/Zy 0789QaXlLEcFTINP/N1zdYthxC7Ust2b2hOwIk6AQFSve2VklJB0PcthmAnKyAUN w6RNjcAM0OkRKxXGVOFH9Y8nYhkiJOM8H3lTDOToZe9e6AuH9Y5Qqvs5y6l+LlQV /5MCVTaoae+XLQgld+txckqr8qlqjE/NwWq1NAEXeVLfEX8RzyM3WVDQAua4u91e 0VrsIyLWnC6RwRIkP7eIeF1K1rMEgZQA2cI6lLDUcLcob/oKjCD6cgpJUHi6vQFs yVIq3i/NPdRohhPS1FUNw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdelvddguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeugeeljedvgfdvjeei ueeiieevudefvedvffegkeffgffffeegvdehieeuvdfgvdenucffohhmrghinhepphhosh htghhrrdgvshenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehpvghtvghrrdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtoh hm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 15 Apr 2023 14:47:09 -0400 (EDT) Message-ID: <766f3799-0269-162f-ba63-4cae34a5534f@enterprisedb.com> Date: Sat, 15 Apr 2023 20:47:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: pgsql: Add grantable MAINTAIN privilege and pg_maintain role. Content-Language: en-US To: Jeff Davis , pgsql-committers@lists.postgresql.org References: From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 14.12.22 02:35, Jeff Davis wrote: > Add grantable MAINTAIN privilege and pg_maintain role. > > Allows VACUUM, ANALYZE, REINDEX, REFRESH MATERIALIZED VIEW, CLUSTER, > and LOCK TABLE. > > Effectively reverts 4441fc704d. Instead of creating separate > privileges for VACUUM, ANALYZE, and other maintenance commands, group > them together under a single MAINTAIN privilege. > > Author: Nathan Bossart > Discussion: https://postgr.es/m/20221212210136.GA449764@nathanxps13 > Discussion: https://postgr.es/m/45224.1670476523@sss.pgh.pa.us This commit removed RangeVarCallbackOwnsTable(), but there is still a mention of it in a comment in src/backend/commands/tablecmds.c. Maybe that mention can simply be removed, or the comment rephrased.