Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFkAB-00014d-MC for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Jan 2023 23:05:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pFkAA-0005Ek-Id for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Jan 2023 23:05:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFkAA-0005Eb-9w for pgsql-hackers@lists.postgresql.org; Wed, 11 Jan 2023 23:05:42 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFkA7-0001XR-14 for pgsql-hackers@lists.postgresql.org; Wed, 11 Jan 2023 23:05:41 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30BN5Wrc769447; Wed, 11 Jan 2023 18:05:33 -0500 From: Tom Lane To: Peter Eisentraut cc: Brar Piening , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Doc: add XML ID attributes to and tags. In-reply-to: <56f62f5e-86d6-70d0-2d5a-49e1480e3c0b@enterprisedb.com> References: <56f62f5e-86d6-70d0-2d5a-49e1480e3c0b@enterprisedb.com> Comments: In-reply-to Peter Eisentraut message dated "Wed, 11 Jan 2023 23:10:07 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <769445.1673478332.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 11 Jan 2023 18:05:32 -0500 Message-ID: <769446.1673478332@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > On 09.01.23 21:08, Tom Lane wrote: >> Doc: add XML ID attributes to and tags. > Any reason the new ids in create_database.sgml deviate from the normal = > naming schemes used everywhere else? Is it to preserve the existing = > create-database-strategy? Maybe we should rename that one and make the = > new ones consistent? You'd have to ask Brar that, I didn't question his choices too much. I have no objection to changing things as you suggest. I'm hesitant to rename very many pre-existing IDs for fear of breaking peoples' bookmarks, but changing create-database-strategy doesn't seem like a big deal. That reminds me that I was going to suggest fixing the few existing variances from the "use '-' not '_'" policy: $ grep 'id=3D"[a-zA-Z0-9-]*_' *sgml ref/*sgml config.sgml: libpq.sgml: libpq.sgml: libpq.sgml: libpq.sgml: pgbuffercache.sgml: ref/pg_checksums.sgml: As you say, this isn't required by the toolchain any longer, but it seems like a good idea to have consistent tag spelling. I'm particularly annoyed by guc-plan-cache_mode, which isn't even consistent with itself let alone every other guc-XXX tag. regards, tom lane