Message-ID: <770040bf2ca4c247b2c88837a3cb00d2798cdde6.camel@j-davis.com>
Subject: Re: pgsql: CREATE DATABASE: make LOCALE apply to all collation
 providers.
From: Jeff Davis <pgsql@j-davis.com>
To: Jeff Davis <jdavis@postgresql.org>, pgsql-committers@lists.postgresql.org
Date: Fri, 16 Jun 2023 13:14:52 -0700
In-Reply-To: <E1qADSG-0026fm-Gd@gemulon.postgresql.org>
References: <E1qADSG-0026fm-Gd@gemulon.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/770040bf2ca4c247b2c88837a3cb00d2798cdde6.camel%40j-davis.com>
Precedence: bulk

On Fri, 2023-06-16 at 17:41 +0000, Jeff Davis wrote:
> CREATE DATABASE: make LOCALE apply to all collation providers.

This created a minor test diff for the test_extensions test for
cs_CZ.UTF-8:

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Djay&dt=3D20=
23-06-16%2018%3A02%3A15&stg=3Dtestmodules-install-check-cs_CZ.UTF-8

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Dhippopotamu=
s&dt=3D2023-06-16%2017%3A43%3A05&stg=3Dtestmodules-install-check-cs_CZ.UTF-=
8

I believe the new behavior is correct, and the test is being run
incorrectly.

The buildfarm members do an initdb with the cs_CZ locale, and then run
the test_extensions test in installcheck mode against that
installation. As expected that creates \dx+ output using the cs_CZ
locale, which sorts "sequence" before "schema", unlike with the C
locale.

The test_extensions Makefile specifies NO_LOCALE=3D1 to avoid this kind
of problem, but that doesn't help during an installcheck.

Regards,
	Jeff Davis