Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjOH7-0001ma-11 for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 16:10:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mjOH5-0002gY-SJ for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 16:10:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjOH5-0002gP-MA for pgsql-committers@lists.postgresql.org; Sat, 06 Nov 2021 16:10:35 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mjOH1-0002qY-P6 for pgsql-committers@lists.postgresql.org; Sat, 06 Nov 2021 16:10:35 +0000 Received: by mail-ed1-x533.google.com with SMTP id b15so24743122edd.7 for ; Sat, 06 Nov 2021 09:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=wVfHKhBODz3o6SiZiGWobEv3DmgOjBxHbHu45VGEC+Q=; b=ATPTapoo8Ano1BHpJ8XVjxoF4u/1trRxev+6VVjT8DORQcha60uhnyO3Y5Bzb4T2x7 tGbFgdKlg+kGKS1TqPqKUSXQ8XeQJ11T5XV/alOqUm+sYUND+eElqcsItg/HLx3nQ7wa lXY5TtfTdV3KCKiGFBKPC8ui0Udy+ZHgjy2u5KUOKymIGNq54wylXD0Rw2ZbSXCQceNd TngNZQZznUIn678tMt+x3rh+Xc1cWJrQHXH8wL3+5+ySBrqNZBpoF7CauzXpm0LGF2JL ajasEEvxwh5/XRoklWs7C6fhhWdSu0fRjKyTm/4RGwz+bGaXPoP1iUVsvscGvr7VOHWW 3mfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=wVfHKhBODz3o6SiZiGWobEv3DmgOjBxHbHu45VGEC+Q=; b=OFv8mYjOoy2NWNkOEbsNkWrkFuZRqjaDarS7MU8CtGnTQrEzBUgGZgQPgeVHLee0mt VBKE9Fls7hnJkcXCoSGWdbGZkhNb2efPGIk7P7FQ2i63LMTO4Y+d3taQ0W9x+Lb89mli Oa0YfQjIhiDei3ZlrwqHFl923nJkexBN6RUHn9CrSZ1SqEZt0/knmxjeqIe+tjnnl59w V0g6ZA+/EpNhOoZOPsaK84dcUSBsdCI/cTIpnIsGIJYUhguF6arCs5dYCDMNoGUqTrBM aQU1hVSvd/kVl8sBMHAguSFt4SzymzU/TzKJXZUUGyB6scGmi7dLJ44i04Bu9DNsZMGy PISA== X-Gm-Message-State: AOAM531orfjuJlLHK1v2QtPiIGxxXbPE18Ip3xeyC8DEMZKBSGwPoq69 LE2WFKzIqIdQKAS1+3BuOfjtdfByFIAFELMOdUfLunSqXh6s/mKkwDTsO36d2EpEzdFWhuhiP2f YYA7zE+66GK6p9B7Mq75dCaKEh2QBoo0vTmSuL7DFpCyW5k55Jwbhk0k40iV+0Vv4xo8Oxmt3L/ Tjg3cihri8UvY0vIWU0H4zXdChS5O8SnUuTSdAOFDfNHdAOXD0KOoFaTfmCTL6 X-Google-Smtp-Source: ABdhPJwA7a7f64gefy7aGoib7dRYvas8C46J67O33eiQooFIS1HSQDjq+nvgJKRkJmQFcTMgyi/o/Q== X-Received: by 2002:a05:6402:3592:: with SMTP id y18mr43089242edc.343.1636215029996; Sat, 06 Nov 2021 09:10:29 -0700 (PDT) Received: from [10.137.0.18] (ip-86-49-251-104.net.upcbroadband.cz. [86.49.251.104]) by smtp.gmail.com with ESMTPSA id dt4sm5841533ejb.27.2021.11.06.09.10.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Nov 2021 09:10:29 -0700 (PDT) Message-ID: <77ac2e24-051b-d57a-b02e-4dbc3306f895@enterprisedb.com> Date: Sat, 6 Nov 2021 17:10:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup. Content-Language: en-US To: Tom Lane , Peter Geoghegan Cc: Robert Haas , pgsql-committers References: <508673.1636209019@sss.pgh.pa.us> From: Tomas Vondra In-Reply-To: <508673.1636209019@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 11/6/21 15:30, Tom Lane wrote: > Peter Geoghegan writes: >> On Fri, Nov 5, 2021 at 7:30 AM Robert Haas wrote: >>> Introduce 'bbstreamer' abstraction to modularize pg_basebackup. > >> I'm seeing a pretty straightforward looking compiler warning following >> this commit: >> bbstreamer_file.c:564:24: warning: unused variable ‘mystreamer’ > > And apparently, that file isn't getting built at all on the MSVC side: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2021-11-06%2003%3A52%3A19 > I got annoyed by the warning so I marked the variable as assert-only. Haven't done anything about the MSVC issue. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company