Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nK33e-0005lJ-0k for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Feb 2022 19:00:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nK33c-0005zN-0w for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Feb 2022 19:00:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nK33b-0005zE-AQ for pgsql-hackers@lists.postgresql.org; Tue, 15 Feb 2022 19:00:11 +0000 Received: from mail-vs1-xe2b.google.com ([2607:f8b0:4864:20::e2b]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nK33X-0007s6-Sr for pgsql-hackers@postgresql.org; Tue, 15 Feb 2022 19:00:10 +0000 Received: by mail-vs1-xe2b.google.com with SMTP id g21so11078146vsp.6 for ; Tue, 15 Feb 2022 11:00:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joeconway.com; s=google; h=message-id:date:mime-version:user-agent:content-language:to:cc :references:from:subject:in-reply-to:content-transfer-encoding; bh=dkoFsBLr957JhRClMGAqfW61dz8RPvYKJ+BC6pPayEg=; b=d7eJOc0MZPG5pCAZMQSdFO6lAUsmRyPcPTb4elZ74WzS01UjvSO0cgXnUO0JNXdOIQ ouBxnliNtDsHwYdhdyTNEsd8igUkzHf35Om8Rl+0PFm3srPKTixFPcx1Bin0SLss1K15 lzWZMY0H1ZRawtiE2lq9e6w0dkgnBkX876dYL7cHnpZD//fp9hS8xb3euFziv2gmf1st Tq7YGdbbElQ9jucZ7vEwrkE7ByqwNT3w227ZzH4uof5Qp741nO1Kg9MawZtGz6sGY3nE uiytIjxxkjgUj5cEVPjYJCH71wJfJg6HpLieu5/+NR6ulhiHu0qWvZcZunmBTrgOPyC3 ewlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=dkoFsBLr957JhRClMGAqfW61dz8RPvYKJ+BC6pPayEg=; b=kROCM3oEk/MqsHXNbBnsMLPiWKkVFheeEky+IfytUrW9++YNC0v0q5POqqm1UqWJmR tOD3JLoE8zbYNy9wdL7e4zreMg9euz5O++ifg2PztsrVsUWALLmCs+kjp6kcIGKLE4tB RdaG/ItE+QFoPlRQvs1zttVNp8/XNsaJBJGFaJ+A5nMNoEP/dLq5++l3SEuoYXF1FFmh 3dOyBlqzl1+55PlT33a9nihjmTWpgUFar9wV3QPm22FODlas0k4mg0EkDA0fHSo5aERa 4oNu1EX2yF5fE4mJxgVfS4q58FQ6yyM34PCNsDMBsYQ9IWyDlS9l7SH3e0u4byP17ifp J+rQ== X-Gm-Message-State: AOAM533DsNAUas/Y1RcK0JPtJQONonNS5+RBlG8jhoEXGVTcTKbNUaGm DxdUBNGe9Ud3YpSUFWSNTptD+QI4sVipeQ== X-Google-Smtp-Source: ABdhPJzgtLOKSD/us0X1KQLHJlNQ6NtDsMwDmseVSNIW/tDFzlNb9CafG58QF958nIO71BOYVZzibQ== X-Received: by 2002:a05:6102:3310:: with SMTP id v16mr129419vsc.56.1644951605636; Tue, 15 Feb 2022 11:00:05 -0800 (PST) Received: from [192.168.4.41] (072-017-018-098.res.spectrum.com. [72.17.18.98]) by smtp.gmail.com with ESMTPSA id z62sm6056314vkg.43.2022.02.15.11.00.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Feb 2022 11:00:05 -0800 (PST) Message-ID: <77f5b16f-cabd-e7e2-db9e-e3e41ff8eec6@joeconway.com> Date: Tue, 15 Feb 2022 14:00:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Robert Haas Cc: Peter Eisentraut , PostgreSQL-development References: <58cca3e9-53b8-e824-7cd4-6e59b4e242b1@joeconway.com> From: Joe Conway Subject: Re: pgsql: Move scanint8() to numutils.c In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2/15/22 13:47, Robert Haas wrote: > On Tue, Feb 15, 2022 at 10:39 AM Joe Conway wrote: >> (moving to hackers) >> >> I guess shame on me for not noticing the thread, but I don't see any >> discussion about the potential for breakage to external projects. >> >> scanint8() is exported, and this change breaks at least two extensions I >> maintain. >> >> A quick scan (no pun intended ;-)) of github shows other potential >> breakage, including at least older (still open source) versions of >> pglogical. > > I don't have a particularly strong view on whether the underlying > change was a good idea here, but the breakage you're talking about > seems pretty easy to fix, unless I'm missing something? I think it > would be a bad idea to make such a change in a minor release without > concern for extension breakage, but in a new major release it doesn't > seem like a problem to me. I'm not saying it is hard to fix, but it seems a bit cavalier to not even discuss the potential for breakage. If nothing else we should flag this as something for the release notes. Joe -- Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure Enterprises Consulting, Training, & Open Source Development