From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Thomas Munro <thomas.munro@enterprisedb.com>,
        Andres Freund <andres@anarazel.de>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add parallel-aware hash joins.
In-reply-to: 
 <CA+TgmoY7JAxRW_UQZAyxH3=JXV3WTFdwfTdyGB3TySj7c1i2yg@mail.gmail.com>
References: <E1eRwXy-0004IK-TO@gemulon.postgresql.org>
 <20171221092940.gbxcszbzsr5khsfr@alap3.anarazel.de>
 <20171221095550.d3e7xhoakcowhu5b@alap3.anarazel.de>
 <CAEepm=3eS6ra8oBCYsYYjPNsPqb2R_TaGQK8SGRFq_7gbP8RUg@mail.gmail.com>
 <CAEepm=0WxwzpHVHt3PcWHBV=L3k3FDb6dvMq1A2Li49LGBa7TA@mail.gmail.com>
 <20171222082203.fl6rpzlqnm4h7h6h@alap3.anarazel.de>
 <CAEepm=04WhyY65BpE2g_8E==ayhBXjV9JbyR-+9N4McmY3SQkQ@mail.gmail.com>
 <30219.1514428346@sss.pgh.pa.us>
 <CAEepm=1OyZcCAxAEWYhmeg0qmWyYF2O2yW7s7A4uVTt-dgRRyQ@mail.gmail.com>
 <CAEepm=2H80cY=DncWKjoSiwaX=xbLcW7dqee+1H5-CQ6pJJnAQ@mail.gmail.com>
 <CAEepm=3GL7H3vxQb0LTJ9KnKhpnvaqOK=yn9p-O8zyjxRgXntA@mail.gmail.com>
 <30655.1514673257@sss.pgh.pa.us>
 <CAEepm=3SeFvsfnnOLSA3tLtBe-rtyL=c+vfzyPCsViBjk521qw@mail.gmail.com>
 <4001.1514678419@sss.pgh.pa.us>
 <CAEepm=2WFQrwDD4rEVKjdPBQ_di_0n=xYST1MDRsucZ=JgDPxg@mail.gmail.com>
 <18190.1514943510@sss.pgh.pa.us>
 <CAEepm=34PDuR69kfYVhmZPgMdy8pSA-MYbpesEN1SR+2oj3Y+w@mail.gmail.com>
 <5187.1515028624@sss.pgh.p!
 a.us> <CAEepm=1uuT8iJxMEsR=jL+3zEi87DB2v0+0H9o_rUXXCZPZT3A@mail.gmail.com>
 <16320.1515046173@sss.pgh.pa.us> <4847.1515081624@sss.pgh.pa.us>
 <CA+TgmoY7JAxRW_UQZAyxH3=JXV3WTFdwfTdyGB3TySj7c1i2yg@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Thu, 04 Jan 2018 11:59:09 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7838.1515085897.1@sss.pgh.pa.us>
Date: Thu, 04 Jan 2018 12:11:37 -0500
Message-ID: <7839.1515085897@sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Jan 4, 2018 at 11:00 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Also, what the devil is happening on skink?

> So, skink is apparently dying during shutdown of a user-connected
> backend, and specifically the one that executed the 'tablespace' test.

Well, yeah, valgrind is burping: the postmaster log is full of

==10544== VALGRINDERROR-BEGIN
==10544== Syscall param epoll_pwait(sigmask) points to unaddressable byte(s)
==10544==    at 0x7011490: epoll_pwait (epoll_pwait.c:42)
==10544==    by 0x4BF40B: WaitEventSetWaitBlock (latch.c:1048)
==10544==    by 0x4BF40B: WaitEventSetWait (latch.c:1000)
==10544==    by 0x3C0B3B: secure_read (be-secure.c:166)
==10544==    by 0x3CCD9E: pq_recvbuf (pqcomm.c:963)
==10544==    by 0x3CDA07: pq_getbyte (pqcomm.c:1006)
==10544==    by 0x4E2A2D: SocketBackend (postgres.c:339)
==10544==    by 0x4E444E: ReadCommand (postgres.c:512)
==10544==    by 0x4E7588: PostgresMain (postgres.c:4085)
==10544==    by 0x4641D0: BackendRun (postmaster.c:4412)
==10544==    by 0x467308: BackendStartup (postmaster.c:4084)
==10544==    by 0x4675F7: ServerLoop (postmaster.c:1757)
==10544==    by 0x4689D4: PostmasterMain (postmaster.c:1365)
==10544==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==10544== 
==10544== VALGRINDERROR-END

But (a) this is happening in multiple branches, and (b) we've not
changed anything near that code in awhile.  I think something broke
in valgrind itself.

			regards, tom lane